Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix popup positioning #1151

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Fix popup positioning #1151

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5967cbb
Fix popup positioning
christianbaroni Nov 23, 2023
d185c3b
Set popup height based on platform
christianbaroni Nov 23, 2023
af09391
Merge branch 'master' into @christian/fix-popup-positioning
christianbaroni Nov 24, 2023
c292877
Merge branch 'master' into @christian/fix-popup-positioning
christianbaroni Nov 26, 2023
0bcda9d
Merge branch 'master' into @christian/fix-popup-positioning
christianbaroni Nov 27, 2023
32fea02
Merge branch 'master' into @christian/fix-popup-positioning
christianbaroni Nov 27, 2023
5904573
Merge branch 'master' into @christian/fix-popup-positioning
DanielSinclair Nov 27, 2023
6c0cdeb
Merge branch 'master' into @christian/fix-popup-positioning
christianbaroni Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/entries/background/handlers/handleProviderRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,27 @@ const MAX_REQUEST_PER_MINUTE = 90;
let minuteTimer: NodeJS.Timeout | null = null;
let secondTimer: NodeJS.Timeout | null = null;

const getPopupTitleBarHeight = (platform: string) => {
if (platform.includes('Mac')) return 28;
if (platform.includes('Win')) return 30;
if (platform.includes('Linux')) return 32;
return 28;
};

const createNewWindow = async (tabId: string) => {
const { setNotificationWindow } = notificationWindowStore.getState();
const currentWindow = await chrome.windows.getCurrent();
const window = await chrome.windows.create({
url: chrome.runtime.getURL('popup.html') + '?tabId=' + tabId,
type: 'popup',
height: POPUP_DIMENSIONS.height + 25,
width: 360,
height:
POPUP_DIMENSIONS.height + getPopupTitleBarHeight(navigator.userAgent),
width: POPUP_DIMENSIONS.width,
left:
(currentWindow.width || POPUP_DIMENSIONS.width) - POPUP_DIMENSIONS.width,
top: 0,
(currentWindow.left || 0) +
(currentWindow.width || POPUP_DIMENSIONS.width) -
POPUP_DIMENSIONS.width,
top: currentWindow.top || 0,
});
setNotificationWindow(tabId, window);
};
Expand Down
Loading