Fix popup positioning

[christianbaroni]

Fixes BX-872

What changed (plus any additional context for devs)

• Fixes the positioning of the popup window that appears when connecting or signing — should now correctly position to the top right of the active browser window
• Adjusts the popup height determination to take into account the estimated size of the popup window's title bar, based on the userAgent

Screen recordings / screenshots

What to test

• When connecting or signing, the popup window should be positioned to the top right of the active browser window
• Popups should now appear on the correct screen if external monitors are being used
• The popup window should be sized correctly and should not be scrollable, at least on Macs

[linear]

BX-872 Popup window bounds should be related to current screen

From Christian:

have noticed though when I have my laptop open and plugged into my monitor, the popup always opens on my laptop screen, even if the chrome window I’m using is on my monitor (maybe unrelated to this)

This is because we call chrome.windows.create with hardcoded top & left. and those should be calculated relative to the current window instead

[github-actions]

Here's the packed extension for this build:
rainbowbx-c7c439c05c690da1d40f61aa1fd56af3bf43450b.zip

[github-actions]

Here's the packed extension for this build:
rainbowbx-6427146f90f45c609c3dafe15d947d34ba2c3251.zip

[greg-schrammel]

looks good
I think arc saves the popup dimensions how you last arranged it, but chrome is right
didn't test with an external monitor

[github-actions]

Here's the packed extension for this build:
rainbowbx-222bfb5cb60dd2267af0d2998fa5f7c41464d819.zip

[github-actions]

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9d69bc37900de5ab8b6d28b7be8d27421e85984c.zip

[DanielSinclair]

Working perfectly on my DisplayLink monitors. Nice 👌

[github-actions]

Here's the packed extension for this build:
rainbowbx-3a9436d6ad00e92da6e9d5b43f2607dbf943603b.zip

[github-actions]

Here's the packed extension for this build:
rainbowbx-e26d048d837fca927dc5f7a80600573cc8434f5b.zip

[github-actions]

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-55d424bd159fb7a8b913f32fcc02c5a10d5b112d.zip