Support to extend default webpacker env for non-standard env #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rails defined custom env is allowed by rails#1304. However Webpacker custom env is not allowed for now. ``` /Users/tricknotes/dummy-app/node_modules/@rails/webpacker/package/config.js:16 delete defaults.extensions ^ TypeError: Cannot convert undefined or null to object ``` This commit allows using user defined env for Webpacker.
tricknotes
force-pushed
the
extend-default-webpacker-env
branch
2 times, most recently
from
53f790a
to
0588462
Compare
Currently, the non-standard env is allowed to use but any webpacker
default config is ignored.
Especially, the developer who use "staging" expects that the environment
is almost the same as "production".
This commit allows to specify the default webpacker env to be extended
by non-standard env.
If someone want to extend webpacker env without this commit, the
following change is required.
``` diff
diff --git a/config/webpack/staging.js b/config/webpack/staging.js
index d7346478..77bb3afa 100644
--- a/config/webpack/staging.js
+++ b/config/webpack/staging.js
@@ -1,3 +1,4 @@
-const environment = require('./environment');
+const Environment = require('@rails/webpacker/package/environments/production');
+const environment = new Environment();
module.exports = environment.toWebpackConfig();
```
tricknotes
force-pushed
the
extend-default-webpacker-env
branch
from
0588462
to
bc73d49
Compare
|
Thanks @tricknotes for your contribution. Just merged #1359, which solves this issue. |
|
Ah, right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the non-standard env is allowed to use but any webpacker default config is ignored.
Especially, the developer who use "staging" expects that the environment is almost the same as "production".
This commit allows to specify the default webpacker env to be extended by non-standard env.
If someone want to extend webpacker env without this commit, the following change is required.
This PR depends on #1350 due to support for non-standard env :<