Allow custom env for Webpacker #1350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tricknotes
force-pushed
the
allow-costom-env
branch
from
b294e61
to
48f6c08
Compare
The Rails defined custom env is allowed by rails#1304. However Webpacker custom env is not allowed for now. ``` /Users/tricknotes/dummy-app/node_modules/@rails/webpacker/package/config.js:16 delete defaults.extensions ^ TypeError: Cannot convert undefined or null to object ``` This commit allows using user defined env for Webpacker.
tricknotes
force-pushed
the
allow-costom-env
branch
from
48f6c08
to
3e2621b
Compare
|
for anyone waiting for this to get into a release, just run: doing that allowed me to deploy to |
|
I'm pinned down to 3.2.x waiting for this 💅 |
|
Thanks @tricknotes again for your contribution. Please see #1359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rails defined custom env is allowed by #1304.
However Webpacker custom env is not allowed for now.
This commit allows using user defined env for Webpacker.