Skip to content

Commit

Permalink
Merge cockroachdb#67593
Browse files Browse the repository at this point in the history 
67593: startupmigrations: rename from sqlmigrations, add doc.go r=ajwerner a=ajwerner

There was nothing particularly `sql` about these migrations except, maybe,
that they had access to sql.

Co-authored-by: Andrew Werner <[email protected]>
  • Loading branch information
@ajwerner
craig[bot] and ajwerner committed Jul 14, 2021
2 parents 1e95fcb + d54cfc7 commit 0e8f534
Show file tree
Hide file tree
Showing 34 changed files with 186 additions and 144 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
/pkg/security/ @cockroachdb/server-prs
/pkg/settings/ @cockroachdb/server-prs
/pkg/sql/ @cockroachdb/sql-queries-noreview
/pkg/sqlmigrations/ @cockroachdb/sql-queries-noreview
/pkg/startupmigrations/ @cockroachdb/sql-queries-noreview
/pkg/streaming/ @cockroachdb/bulk-prs
/pkg/testutils/ @cockroachdb/test-eng
/pkg/ts/ @cockroachdb/kv
Expand Down
4 changes: 2 additions & 2 deletions pkg/BUILD.bazel
View file
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ ALL_TESTS = [
"//pkg/sql/tests:tests_test",
"//pkg/sql/types:types_test",
"//pkg/sql:sql_test",
"//pkg/sqlmigrations/leasemanager:leasemanager_test",
"//pkg/sqlmigrations:sqlmigrations_test",
"//pkg/startupmigrations/leasemanager:leasemanager_test",
"//pkg/startupmigrations:startupmigrations_test",
"//pkg/storage/cloud/amazon:amazon_test",
"//pkg/storage/cloud/azure:azure_test",
"//pkg/storage/cloud/gcp:gcp_test",
Expand Down
38 changes: 19 additions & 19 deletions pkg/base/testing_knobs.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,23 @@ type ModuleTestingKnobs interface {
// TestingKnobs contains facilities for controlling various parts of the
// system for testing.
type TestingKnobs struct {
Store ModuleTestingKnobs
KVClient ModuleTestingKnobs
RangeFeed ModuleTestingKnobs
SQLExecutor ModuleTestingKnobs
SQLLeaseManager ModuleTestingKnobs
SQLSchemaChanger ModuleTestingKnobs
SQLNewSchemaChanger ModuleTestingKnobs
SQLTypeSchemaChanger ModuleTestingKnobs
GCJob ModuleTestingKnobs
PGWireTestingKnobs ModuleTestingKnobs
SQLMigrationManager ModuleTestingKnobs
DistSQL ModuleTestingKnobs
SQLEvalContext ModuleTestingKnobs
NodeLiveness ModuleTestingKnobs
Server ModuleTestingKnobs
TenantTestingKnobs ModuleTestingKnobs
JobsTestingKnobs ModuleTestingKnobs
BackupRestore ModuleTestingKnobs
MigrationManager ModuleTestingKnobs
Store ModuleTestingKnobs
KVClient ModuleTestingKnobs
RangeFeed ModuleTestingKnobs
SQLExecutor ModuleTestingKnobs
SQLLeaseManager ModuleTestingKnobs
SQLSchemaChanger ModuleTestingKnobs
SQLNewSchemaChanger ModuleTestingKnobs
SQLTypeSchemaChanger ModuleTestingKnobs
GCJob ModuleTestingKnobs
PGWireTestingKnobs ModuleTestingKnobs
StartupMigrationManager ModuleTestingKnobs
DistSQL ModuleTestingKnobs
SQLEvalContext ModuleTestingKnobs
NodeLiveness ModuleTestingKnobs
Server ModuleTestingKnobs
TenantTestingKnobs ModuleTestingKnobs
JobsTestingKnobs ModuleTestingKnobs
BackupRestore ModuleTestingKnobs
MigrationManager ModuleTestingKnobs
}
48 changes: 24 additions & 24 deletions pkg/ccl/changefeedccl/helpers_tenant_shim_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,30 +51,30 @@ func (t *testServerShim) ServingSQLAddr() string {
return t.SQLAddr()
}

func (t *testServerShim) Stopper() *stop.Stopper { panic(unsupportedShimMethod) }
func (t *testServerShim) Start(context.Context) error { panic(unsupportedShimMethod) }
func (t *testServerShim) Node() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) NodeID() roachpb.NodeID { panic(unsupportedShimMethod) }
func (t *testServerShim) ClusterID() uuid.UUID { panic(unsupportedShimMethod) }
func (t *testServerShim) ServingRPCAddr() string { panic(unsupportedShimMethod) }
func (t *testServerShim) RPCAddr() string { panic(unsupportedShimMethod) }
func (t *testServerShim) DB() *kv.DB { panic(unsupportedShimMethod) }
func (t *testServerShim) RPCContext() *rpc.Context { panic(unsupportedShimMethod) }
func (t *testServerShim) LeaseManager() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) InternalExecutor() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) ExecutorConfig() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) Tracer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) GossipI() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) RangeFeedFactory() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) Clock() *hlc.Clock { panic(unsupportedShimMethod) }
func (t *testServerShim) DistSenderI() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) MigrationServer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) SQLServer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) SQLLivenessProvider() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) SQLMigrationsManager() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) NodeLiveness() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) HeartbeatNodeLiveness() error { panic(unsupportedShimMethod) }
func (t *testServerShim) NodeDialer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) Stopper() *stop.Stopper { panic(unsupportedShimMethod) }
func (t *testServerShim) Start(context.Context) error { panic(unsupportedShimMethod) }
func (t *testServerShim) Node() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) NodeID() roachpb.NodeID { panic(unsupportedShimMethod) }
func (t *testServerShim) ClusterID() uuid.UUID { panic(unsupportedShimMethod) }
func (t *testServerShim) ServingRPCAddr() string { panic(unsupportedShimMethod) }
func (t *testServerShim) RPCAddr() string { panic(unsupportedShimMethod) }
func (t *testServerShim) DB() *kv.DB { panic(unsupportedShimMethod) }
func (t *testServerShim) RPCContext() *rpc.Context { panic(unsupportedShimMethod) }
func (t *testServerShim) LeaseManager() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) InternalExecutor() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) ExecutorConfig() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) Tracer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) GossipI() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) RangeFeedFactory() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) Clock() *hlc.Clock { panic(unsupportedShimMethod) }
func (t *testServerShim) DistSenderI() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) MigrationServer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) SQLServer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) SQLLivenessProvider() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) StartupMigrationsManager() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) NodeLiveness() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) HeartbeatNodeLiveness() error { panic(unsupportedShimMethod) }
func (t *testServerShim) NodeDialer() interface{} { panic(unsupportedShimMethod) }
func (t *testServerShim) SetDistSQLSpanResolver(spanResolver interface{}) {
panic(unsupportedShimMethod)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/BUILD.bazel
View file
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ go_library(
"//pkg/sql/row",
"//pkg/sql/sem/builtins",
"//pkg/sql/sem/tree",
"//pkg/sqlmigrations",
"//pkg/startupmigrations",
"//pkg/storage",
"//pkg/storage/cloud",
"//pkg/storage/cloud/userfile",
Expand Down
4 changes: 2 additions & 2 deletions pkg/cli/gen.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/cli/clisqlexec"
"github.com/cockroachdb/cockroach/pkg/settings"
"github.com/cockroachdb/cockroach/pkg/settings/cluster"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
"github.com/cockroachdb/errors/oserror"
"github.com/spf13/cobra"
"github.com/spf13/cobra/doc"
Expand Down Expand Up @@ -234,7 +234,7 @@ Output the list of cluster settings known to this binary.
defaultVal = sm.SettingsListDefault()
} else {
defaultVal = setting.String(&s.SV)
if override, ok := sqlmigrations.SettingsDefaultOverrides[name]; ok {
if override, ok := startupmigrations.SettingsDefaultOverrides[name]; ok {
defaultVal = override
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/migration/migrations/BUILD.bazel
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ go_library(
"//pkg/sql/catalog/systemschema",
"//pkg/sql/sem/tree",
"//pkg/sql/sqlutil",
"//pkg/sqlmigrations",
"//pkg/startupmigrations",
"//pkg/util/encoding",
"//pkg/util/hlc",
"//pkg/util/log",
Expand Down
4 changes: 2 additions & 2 deletions pkg/migration/migrations/join_tokens.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ import (
"github.com/cockroachdb/cockroach/pkg/clusterversion"
"github.com/cockroachdb/cockroach/pkg/migration"
"github.com/cockroachdb/cockroach/pkg/sql/catalog/systemschema"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
)

func joinTokensTableMigration(
ctx context.Context, _ clusterversion.ClusterVersion, d migration.TenantDeps,
) error {
return sqlmigrations.CreateSystemTable(
return startupmigrations.CreateSystemTable(
ctx, d.DB, d.Codec, d.Settings, systemschema.JoinTokensTable,
)
}
6 changes: 3 additions & 3 deletions pkg/migration/migrations/sql_stats.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@ import (
"github.com/cockroachdb/cockroach/pkg/clusterversion"
"github.com/cockroachdb/cockroach/pkg/migration"
"github.com/cockroachdb/cockroach/pkg/sql/catalog/systemschema"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
)

func sqlStatementStatsTableMigration(
ctx context.Context, _ clusterversion.ClusterVersion, d migration.TenantDeps,
) error {
return sqlmigrations.CreateSystemTable(
return startupmigrations.CreateSystemTable(
ctx, d.DB, d.Codec, d.Settings, systemschema.StatementStatisticsTable,
)
}

func sqlTransactionStatsTableMigration(
ctx context.Context, _ clusterversion.ClusterVersion, d migration.TenantDeps,
) error {
return sqlmigrations.CreateSystemTable(
return startupmigrations.CreateSystemTable(
ctx, d.DB, d.Codec, d.Settings, systemschema.TransactionStatisticsTable,
)
}
4 changes: 2 additions & 2 deletions pkg/server/BUILD.bazel
View file
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ go_library(
"//pkg/sql/stats",
"//pkg/sql/stmtdiagnostics",
"//pkg/sql/types",
"//pkg/sqlmigrations",
"//pkg/startupmigrations",
"//pkg/storage",
"//pkg/storage/cloud",
"//pkg/storage/enginepb",
Expand Down Expand Up @@ -323,7 +323,7 @@ go_test(
"//pkg/sql/sem/tree",
"//pkg/sql/sqlstats",
"//pkg/sql/tests",
"//pkg/sqlmigrations",
"//pkg/startupmigrations",
"//pkg/storage",
"//pkg/storage/enginepb",
"//pkg/testutils",
Expand Down
4 changes: 2 additions & 2 deletions pkg/server/migration_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/roachpb"
"github.com/cockroachdb/cockroach/pkg/server/serverpb"
"github.com/cockroachdb/cockroach/pkg/settings/cluster"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
Expand Down Expand Up @@ -254,7 +254,7 @@ func TestUpgradeHappensAfterMigrations(t *testing.T) {
Server: &TestingKnobs{
BinaryVersionOverride: clusterversion.TestingBinaryMinSupportedVersion,
},
SQLMigrationManager: &sqlmigrations.MigrationManagerTestingKnobs{
StartupMigrationManager: &startupmigrations.MigrationManagerTestingKnobs{
AfterEnsureMigrations: func() {
// Try to encourage other goroutines to run.
const N = 100
Expand Down
2 changes: 1 addition & 1 deletion pkg/server/server.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1897,7 +1897,7 @@ func (s *Server) PreStart(ctx context.Context) error {
s.ctSender.Run(ctx, state.nodeID)

// Attempt to upgrade cluster version now that the sql server has been
// started. At this point we know that all sqlmigrations have successfully
// started. At this point we know that all startupmigrations have successfully
// been run so it is safe to upgrade to the binary's current version.
s.startAttemptUpgrade(ctx)

Expand Down
16 changes: 8 additions & 8 deletions pkg/server/server_sql.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/sqlutil"
"github.com/cockroachdb/cockroach/pkg/sql/stats"
"github.com/cockroachdb/cockroach/pkg/sql/stmtdiagnostics"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
"github.com/cockroachdb/cockroach/pkg/storage"
"github.com/cockroachdb/cockroach/pkg/storage/cloud"
"github.com/cockroachdb/cockroach/pkg/util/envutil"
Expand Down Expand Up @@ -112,7 +112,7 @@ type SQLServer struct {
// shared between the sql.Server and the statusServer.
sessionRegistry *sql.SessionRegistry
jobRegistry *jobs.Registry
sqlmigrationsMgr *sqlmigrations.Manager
startupMigrationsMgr *startupmigrations.Manager
statsRefresher *stats.Refresher
temporaryObjectCleaner *sql.TemporaryObjectCleaner
internalMemMetrics sql.MemoryMetrics
Expand Down Expand Up @@ -844,9 +844,9 @@ func (s *SQLServer) preStart(
// in an acceptable form for this version of the software.
// We have to do this after actually starting up the server to be able to
// seamlessly use the kv client against other nodes in the cluster.
var mmKnobs sqlmigrations.MigrationManagerTestingKnobs
if migrationManagerTestingKnobs := knobs.SQLMigrationManager; migrationManagerTestingKnobs != nil {
mmKnobs = *migrationManagerTestingKnobs.(*sqlmigrations.MigrationManagerTestingKnobs)
var mmKnobs startupmigrations.MigrationManagerTestingKnobs
if migrationManagerTestingKnobs := knobs.StartupMigrationManager; migrationManagerTestingKnobs != nil {
mmKnobs = *migrationManagerTestingKnobs.(*startupmigrations.MigrationManagerTestingKnobs)
}

s.leaseMgr.RefreshLeases(ctx, stopper, s.execCfg.DB)
Expand All @@ -869,7 +869,7 @@ func (s *SQLServer) preStart(
DistSQLMode: sessiondata.DistSQLOff,
},
})
sqlmigrationsMgr := sqlmigrations.NewManager(
startupMigrationsMgr := startupmigrations.NewManager(
stopper,
s.execCfg.DB,
s.execCfg.Codec,
Expand All @@ -880,7 +880,7 @@ func (s *SQLServer) preStart(
s.execCfg.Settings,
s.jobRegistry,
)
s.sqlmigrationsMgr = sqlmigrationsMgr // only for testing via TestServer
s.startupMigrationsMgr = startupMigrationsMgr // only for testing via TestServer

if err := s.jobRegistry.Start(ctx, stopper); err != nil {
return err
Expand Down Expand Up @@ -919,7 +919,7 @@ func (s *SQLServer) preStart(
}

// Run startup migrations (note: these depend on jobs subsystem running).
if err := sqlmigrationsMgr.EnsureMigrations(ctx, bootstrapVersion); err != nil {
if err := startupMigrationsMgr.EnsureMigrations(ctx, bootstrapVersion); err != nil {
return errors.Wrap(err, "ensuring SQL migrations")
}

Expand Down
10 changes: 5 additions & 5 deletions pkg/server/testserver.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/physicalplan"
"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
"github.com/cockroachdb/cockroach/pkg/sql/sessiondata"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
"github.com/cockroachdb/cockroach/pkg/storage"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/ts"
Expand Down Expand Up @@ -351,10 +351,10 @@ func (ts *TestServer) JobRegistry() interface{} {
return nil
}

// SQLMigrationsManager returns the *sqlmigrations.Manager as an interface{}.
func (ts *TestServer) SQLMigrationsManager() interface{} {
// StartupMigrationsManager returns the *startupmigrations.Manager as an interface{}.
func (ts *TestServer) StartupMigrationsManager() interface{} {
if ts != nil {
return ts.sqlServer.sqlmigrationsMgr
return ts.sqlServer.startupMigrationsMgr
}
return nil
}
Expand Down Expand Up @@ -628,7 +628,7 @@ func (ts *TestServer) ExpectedInitialRangeCount() (int, error) {
func ExpectedInitialRangeCount(
db *kv.DB, defaultZoneConfig *zonepb.ZoneConfig, defaultSystemZoneConfig *zonepb.ZoneConfig,
) (int, error) {
descriptorIDs, err := sqlmigrations.ExpectedDescriptorIDs(
descriptorIDs, err := startupmigrations.ExpectedDescriptorIDs(
context.Background(), db, keys.SystemSQLCodec, defaultZoneConfig, defaultSystemZoneConfig,
)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/sql/BUILD.bazel
View file
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ go_test(
"//pkg/sql/stmtdiagnostics",
"//pkg/sql/tests",
"//pkg/sql/types",
"//pkg/sqlmigrations",
"//pkg/startupmigrations",
"//pkg/storage",
"//pkg/storage/cloudimpl",
"//pkg/testutils",
Expand Down
2 changes: 1 addition & 1 deletion pkg/sql/catalog/lease/lease_internal_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ func TestLeaseAcquireAndReleaseConcurrently(t *testing.T) {
defer leaktest.AfterTest(t)()

skip.WithIssue(t, 51798, "fails in the presence of migrations requiring backfill, "+
"but cannot import sqlmigrations")
"but cannot import startupmigrations")

// Result is a struct for moving results to the main result routine.
type Result struct {
Expand Down
4 changes: 2 additions & 2 deletions pkg/sql/create_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/catalog/catalogkv"
"github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb"
"github.com/cockroachdb/cockroach/pkg/sql/tests"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
Expand Down Expand Up @@ -96,7 +96,7 @@ func TestDatabaseDescriptor(t *testing.T) {
if kvs, err := kvDB.Scan(ctx, start, start.PrefixEnd(), 0 /* maxRows */); err != nil {
t.Fatal(err)
} else {
descriptorIDs, err := sqlmigrations.ExpectedDescriptorIDs(
descriptorIDs, err := startupmigrations.ExpectedDescriptorIDs(
ctx, kvDB, codec, &s.(*server.TestServer).Cfg.DefaultZoneConfig, &s.(*server.TestServer).Cfg.DefaultSystemZoneConfig,
)
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions pkg/sql/drop_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/row"
"github.com/cockroachdb/cockroach/pkg/sql/sqltestutils"
"github.com/cockroachdb/cockroach/pkg/sql/tests"
"github.com/cockroachdb/cockroach/pkg/sqlmigrations"
"github.com/cockroachdb/cockroach/pkg/startupmigrations"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/jobutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
Expand Down Expand Up @@ -852,7 +852,7 @@ func TestDropTableWhileUpgradingFormat(t *testing.T) {

params, _ := tests.CreateTestServerParams()
params.Knobs = base.TestingKnobs{
SQLMigrationManager: &sqlmigrations.MigrationManagerTestingKnobs{
StartupMigrationManager: &startupmigrations.MigrationManagerTestingKnobs{
DisableBackfillMigrations: true,
},
}
Expand Down Expand Up @@ -1147,7 +1147,7 @@ func TestDropNameReuse(t *testing.T) {

params, _ := tests.CreateTestServerParams()
params.Knobs = base.TestingKnobs{
SQLMigrationManager: &sqlmigrations.MigrationManagerTestingKnobs{
StartupMigrationManager: &startupmigrations.MigrationManagerTestingKnobs{
DisableBackfillMigrations: true,
},
}
Expand Down
Loading

0 comments on commit 0e8f534

Please sign in to comment.