Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startupmigrations: rename from sqlmigrations, add doc.go #67593

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

ajwerner
Copy link
Contributor

There was nothing particularly sql about these migrations except, maybe,
that they had access to sql.

@ajwerner ajwerner requested review from a team as code owners July 14, 2021 12:42
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner force-pushed the ajwerner/rename-sqlmigrations branch from bb8078d to 9077308 Compare July 14, 2021 12:55
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only glanced at the diff since it all looks mechanical, let me know if there's anything that needs more than a stamp.

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 32 of 32 files at r1, 1 of 2 files at r2.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz and @nvanbenschoten)

@ajwerner ajwerner force-pushed the ajwerner/rename-sqlmigrations branch from 9077308 to 40c7d23 Compare July 14, 2021 13:40
ajwerner added 2 commits July 14, 2021 10:29
There was nothing particularly `sql` about these migrations except, maybe,
that they had access to sql.

Release note: None
Release note: None
@ajwerner ajwerner force-pushed the ajwerner/rename-sqlmigrations branch from 40c7d23 to d54cfc7 Compare July 14, 2021 14:30
@ajwerner
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 14, 2021

Build succeeded:

@craig craig bot merged commit 0e8f534 into cockroachdb:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants