Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal routing #6541

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Remove internal routing #6541

merged 4 commits into from
Sep 28, 2020

Conversation

palango
Copy link
Contributor

@palango palango commented Sep 15, 2020

Description

Fixes: #6496

Remove internal routing.

Note: This doesn't remove ContractReceiveRouteNew yet, as it is used by the connection manager.

@karlb karlb marked this pull request as draft September 17, 2020 08:32
@palango palango changed the title WIP: Remove internal routing Remove internal routing Sep 21, 2020
@karlb karlb marked this pull request as ready for review September 28, 2020 08:49
palango and others added 4 commits September 28, 2020 11:00
We don't want to track all events for all channels to improve
performance and simplify the code. This breaks the connection manager as
it is now. We're about to make a decision on how to replace the existing
connection manager. For now, just disable the tests to allow development
to continue.
Copy link
Contributor

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Smaller state, less cases to handle, one dependency less and less code and probably more simplifications enabled by this.

@karlb karlb merged commit 60bdda8 into raiden-network:develop Sep 28, 2020
@karlb karlb deleted the remove-internal-routing branch September 28, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Internal Routing
2 participants