Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Internal Routing #6496

Closed
3 of 4 tasks
karlb opened this issue Aug 28, 2020 · 0 comments · Fixed by #6541
Closed
3 of 4 tasks

Remove Internal Routing #6496

karlb opened this issue Aug 28, 2020 · 0 comments · Fixed by #6541

Comments

@karlb
Copy link
Contributor

karlb commented Aug 28, 2020

Problems With Internal Routing

  • Does not know about fee schedule. It currently always assumes 2% fees for the whole payment, which is expensive, but can still be too low in some cases
  • Forces the client to build a representation of the whole network. This makes syncing the raiden client on mainnet at startup horrible slow (See Reduce time for initial sync by providing a JSON #6209).
  • Current implementation has several limitations. Better implemantations would duplicate more code from the PFS.
  • Existing problems will only grow bigger with new features (e.g. better support for token swaps)
  • Not tested in SP
  • Not manually tested on Alderaan release

Todos

Due to these problems, it is better to remove the internal routing and rely on the PFS for payments through non-direct channels.

  • Provide way to do non-direct payments in integration test without internal routing (give routes explicitly?)
  • Remove usage of internal routing from tests (delete test that are only about testing the internal routing)
  • Remove internal routing from CLI flags and documentation
  • Remove internal routing code

Followups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants