Skip to content

Commit

Permalink
fix: Fixing WAF test (Azure#3823)
Browse files Browse the repository at this point in the history
## Description
Fixing WAF test


Fixes Azure#3812 
Fixes Azure#3824
Closes Azure#3812 
Closes Azure#3824

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.cache.redis](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml/badge.svg?branch=fix%2Fissues%2F3812)](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Jack Tracey <[email protected]>
  • Loading branch information
hundredacres and jtracey93 authored Nov 22, 2024
1 parent b7ee1d6 commit 16bbef6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
5 changes: 0 additions & 5 deletions avm/res/cache/redis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,6 @@ module redis 'br/public:avm/res/cache/redis:<version>' = {
workspaceResourceId: '<workspaceResourceId>'
}
]
enableNonSslPort: true
location: '<location>'
lock: {
kind: 'CanNotDelete'
Expand Down Expand Up @@ -876,9 +875,6 @@ module redis 'br/public:avm/res/cache/redis:<version>' = {
}
]
},
"enableNonSslPort": {
"value": true
},
"location": {
"value": "<location>"
},
Expand Down Expand Up @@ -978,7 +974,6 @@ param diagnosticSettings = [
workspaceResourceId: '<workspaceResourceId>'
}
]
param enableNonSslPort = true
param location = '<location>'
param lock = {
kind: 'CanNotDelete'
Expand Down
6 changes: 3 additions & 3 deletions avm/res/cache/redis/linked-servers/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "6993324639761594928"
"version": "0.31.92.45157",
"templateHash": "4764248912015671674"
},
"name": "Redis Cache Linked Servers",
"description": "This module connects a primary and secondary Redis Cache together for geo-replication.",
Expand Down Expand Up @@ -98,4 +98,4 @@
"value": "[resourceGroup().name]"
}
}
}
}
1 change: 0 additions & 1 deletion avm/res/cache/redis/tests/e2e/waf-aligned/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ module testDeployment '../../../main.bicep' = [
workspaceResourceId: diagnosticDependencies.outputs.logAnalyticsWorkspaceResourceId
}
]
enableNonSslPort: true
lock: {
kind: 'CanNotDelete'
name: 'myCustomLockName'
Expand Down

0 comments on commit 16bbef6

Please sign in to comment.