[AVM Module Issue]: Redis Cache - WAF-Aligned Example is not WAF Aligned due to enableNonSSLPort
#3812
Closed
1 task done
Assignees
Labels
Class: Resource Module 📦
This is a resource module
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: Security Bug 🔒
This is a security bug
Comments
jtracey93
added
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: Security Bug 🔒
|
@jtracey93, thanks for submitting this issue for the Important A member of the @Azure/avm-res-cache-redis-module-owners-bicep or @Azure/avm-res-cache-redis-module-contributors-bicep team will review it soon! |
jtracey93
added a commit
that referenced
this issue
Nov 22, 2024
## Description Fixing WAF test Fixes #3812 Fixes #3824 Closes #3812 Closes #3824 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Jack Tracey <[email protected]>
](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml){kind=link}
github-project-automation
bot
moved this from Needs: Triage
to Done
in AVM - Module Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for previous/existing GitHub issues
Issue Type?
Security Bug
Module Name
avm/res/cache/redis
(Optional) Module Version
No response
Description
The WAF Aligned test/example sets the
enableNonSSLPortproperty to true which goes against the WAF Security Pillar Recommendations https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/cache/redis/tests/e2e/waf-aligned/main.test.bicep#L84Can we update the test/example to not set this property or set it to
false(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: