Update k3d create commands #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix error when no branch changes Signed-off-by: Brooke Hamilton <[email protected]> * Remove extra commit Signed-off-by: Brooke Hamilton <[email protected]> * Add comments Signed-off-by: Brooke Hamilton <[email protected]> * Fix branch name env var Signed-off-by: Brooke Hamilton <[email protected]> * Clarify comments Signed-off-by: Brooke Hamilton <[email protected]> * Add example Signed-off-by: Brooke Hamilton <[email protected]> --------- Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Done! Thank you! 🚀 |
|
I pushed some changes to the edge branch of the repo so that might be the cause for the test failures. Should this branch target edge instead so the PR includes up those changes? @Reshrahim |
OK I will switch the PR to target the edge branch. Thank you! |
lakshmimsft
approved these changes
Aug 14, 2024
vishwahiremat
pushed a commit
to vishwahiremat/samples
that referenced
this pull request
Aug 15, 2024
* Upmerge fix (radius-project#1649) * Fix error when no branch changes Signed-off-by: Brooke Hamilton <[email protected]> * Remove extra commit Signed-off-by: Brooke Hamilton <[email protected]> * Add comments Signed-off-by: Brooke Hamilton <[email protected]> * Fix branch name env var Signed-off-by: Brooke Hamilton <[email protected]> * Clarify comments Signed-off-by: Brooke Hamilton <[email protected]> * Add example Signed-off-by: Brooke Hamilton <[email protected]> --------- Signed-off-by: Brooke Hamilton <[email protected]> * Update k3d create commands Signed-off-by: Brooke Hamilton <[email protected]> * Add comment describing the k3d configuration Signed-off-by: Brooke Hamilton <[email protected]> --------- Signed-off-by: Brooke Hamilton <[email protected]> Signed-off-by: Vishwanath Hiremath <[email protected]>
vishwahiremat
added a commit
that referenced
this pull request
Aug 15, 2024
…file (#1710) * Update k3d create commands (#1683) * Upmerge fix (#1649) * Fix error when no branch changes Signed-off-by: Brooke Hamilton <[email protected]> * Remove extra commit Signed-off-by: Brooke Hamilton <[email protected]> * Add comments Signed-off-by: Brooke Hamilton <[email protected]> * Fix branch name env var Signed-off-by: Brooke Hamilton <[email protected]> * Clarify comments Signed-off-by: Brooke Hamilton <[email protected]> * Add example Signed-off-by: Brooke Hamilton <[email protected]> --------- Signed-off-by: Brooke Hamilton <[email protected]> * Update k3d create commands Signed-off-by: Brooke Hamilton <[email protected]> * Add comment describing the k3d configuration Signed-off-by: Brooke Hamilton <[email protected]> --------- Signed-off-by: Brooke Hamilton <[email protected]> Signed-off-by: Vishwanath Hiremath <[email protected]> * adding aws credential command changes to workflow files Signed-off-by: Vishwanath Hiremath <[email protected]> --------- Signed-off-by: Brooke Hamilton <[email protected]> Signed-off-by: Vishwanath Hiremath <[email protected]> Co-authored-by: Brooke Hamilton <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the commands used for creating a k3d cluster by adding a parameter to
k3d cluster createto disable the default load balancer. The default load balancer was conflicting with the load balancer deployed by Radius. See the issue reference linked below for details.Note:
traefik@server:0was changed totraefik@server:*to indicate that all instances should be affected, not just the one at index zero.Issue reference
Fixes: radius-project/radius#7637