Skip to content

Commit

Permalink
Adding rad credential register aws command changes in the workflow …
Browse files Browse the repository at this point in the history
…file (#1710)

* Update k3d create commands (#1683)

* Upmerge fix (#1649)

* Fix error when no branch changes

Signed-off-by: Brooke Hamilton <[email protected]>

* Remove extra commit

Signed-off-by: Brooke Hamilton <[email protected]>

* Add comments

Signed-off-by: Brooke Hamilton <[email protected]>

* Fix branch name env var

Signed-off-by: Brooke Hamilton <[email protected]>

* Clarify comments

Signed-off-by: Brooke Hamilton <[email protected]>

* Add example

Signed-off-by: Brooke Hamilton <[email protected]>

---------

Signed-off-by: Brooke Hamilton <[email protected]>

* Update k3d create commands

Signed-off-by: Brooke Hamilton <[email protected]>

* Add comment describing the k3d configuration

Signed-off-by: Brooke Hamilton <[email protected]>

---------

Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Vishwanath Hiremath <[email protected]>

* adding aws credential command changes to workflow files

Signed-off-by: Vishwanath Hiremath <[email protected]>

---------

Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Vishwanath Hiremath <[email protected]>
Co-authored-by: Brooke Hamilton <[email protected]>
  • Loading branch information
vishwahiremat and brooke-hamilton authored Aug 15, 2024
1 parent 3b6fa20 commit 81006a7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ jobs:
fi
if [[ "${{ matrix.credential }}" == "aws" ]]; then
rad env update default --aws-region ${{ env.AWS_REGION }} --aws-account-id ${{ secrets.AWS_ACCOUNT_ID }}
rad credential register aws --access-key-id ${{ secrets.AWS_ACCESS_KEY_ID }} --secret-access-key ${{ secrets.AWS_SECRET_ACCESS_KEY }}
rad credential register aws access-key --access-key-id ${{ secrets.AWS_ACCESS_KEY_ID }} --secret-access-key ${{ secrets.AWS_SECRET_ACCESS_KEY }}
fi
## This step is temporary until we have Recipe Packs for Azure & AWS and update the eShop sample
- name: Initialize eShop environments
Expand Down
2 changes: 1 addition & 1 deletion samples/eshop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This reference app is a "radified" version of the [eShop on containers](https://
1. Set provider credentials to authenticate to your cloud provider (choose which type of hosting infrastructure you wish to use):
```bash
# AWS
rad credential register aws --aws-access-key-id <your-aws-access-key-id> --aws-secret-access-key <your-aws-secret-access-key>
rad credential register aws access-key --aws-access-key-id <your-aws-access-key-id> --aws-secret-access-key <your-aws-secret-access-key>

# Azure
rad credential register azure sp --client-id <your-azure-service-principal-client-id> --client-secret <your-azure-service-principal-client-secret> --tenant-id <your-azure-service-principal-tenant-id>
Expand Down

0 comments on commit 81006a7

Please sign in to comment.