Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git signoff to the commit in the upmerge workflow #1299

Merged

Conversation

brooke-hamilton
Copy link
Contributor

@brooke-hamilton brooke-hamilton commented Nov 27, 2024

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This pull request includes a change to the .github/workflows/upmerge.yaml file. The change ensures that commits are signed off when performing an upmerge to the edge branch.

Git log entries for the commit will now look like this, which satisfies the DCO requirement:

Author: Radius CI Bot <[email protected]>
Date:   Wed Nov 27 14:52:43 2024 +0000

    Upmerge to edge
    
    Signed-off-by: Radius CI Bot <[email protected]>

Issue reference

Fixes: #1270

Signed-off-by: Brooke Hamilton <[email protected]>
@lakshmimsft
Copy link
Contributor

confirming: this is meant to be merged into v0.40 branch, right? and not edge?

@brooke-hamilton
Copy link
Contributor Author

confirming: this is meant to be merged into v0.40 branch, right? and not edge?

Yes - the workflow is run from the default branch, which is currently v0.40. All changes, including this one, will be merged to the edge branch when the workflow is run.

@brooke-hamilton brooke-hamilton merged commit c753c7a into radius-project:v0.40 Nov 30, 2024
9 checks passed
@brooke-hamilton brooke-hamilton deleted the upmerge-signoff branch November 30, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add signoff to Upmerge docs to edge workflow
3 participants