Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signoff to Upmerge docs to edge workflow #1270

Closed
willdavsmith opened this issue Nov 8, 2024 · 4 comments · Fixed by #1299
Closed

Add signoff to Upmerge docs to edge workflow #1270

willdavsmith opened this issue Nov 8, 2024 · 4 comments · Fixed by #1299
Assignees

Comments

@willdavsmith
Copy link
Contributor

willdavsmith commented Nov 8, 2024

The Upmerge docs to edge workflow does not include a signoff message in the commit:

git merge -m "Upmerge to edge" origin/$SOURCE_BRANCH

This causes DCO to fail during the release process. We should add a signoff flag to the git merge command.

AB#13660

@ytimocin
Copy link
Contributor

Closing this now @willdavsmith. You can re-open if it is not fixed already.

@kachawla
Copy link
Contributor

This hasn't been fixed yet, re-opening and removing triage label.

@kachawla kachawla reopened this Nov 22, 2024
@kachawla kachawla removed the triaged label Nov 22, 2024
@ytimocin
Copy link
Contributor

Needs to be worked on. The commit that added the sign-off was removed.

@brooke-hamilton
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants