Pass kwargs through moments & add progressbar #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
force-pushed
the
kwargs_all_around
branch
from
221b74a
to
5389323
Compare
…can also provide a desc
…ust silently ignore it
keflavich
force-pushed
the
kwargs_all_around
branch
from
f1167db
to
03cb090
Compare
e-koch
approved these changes
Oct 18, 2024
e-koch
approved these changes
Oct 18, 2024
|
Merging. Test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moments didn't allow progressbars, which resulted in an annoying asymmetry if I wanted to have a progressbar for all expensive operations.
(Depends on #913)