Progressbar: switch to tqdm, add description #913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
requested changes
Sep 5, 2024
|
I'm OK with that. @e-koch, you good with just making tqdm a requirement? |
|
agreed. as Tom points out, it's lightweight and simplifies things. |
|
I've added tqdm as a dependency and refactored to use it - but the usage of progressbars is still a little non-tqdm-like. |
…can also provide a desc
…ust silently ignore it
keflavich
force-pushed
the
progressbar_desc
branch
from
c42f3ec
to
0fd643e
Compare
|
@keflavich can we close this now that #923 is merged? |
|
Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title: there are a lot of progressbars scattered throughout spectral-cube, and it can be tricky to track down where they are. Adding labels should help.