Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fixes to the stacking code #465

Merged
merged 7 commits into from
Feb 7, 2018
Merged

Possible fixes to the stacking code #465

merged 7 commits into from
Feb 7, 2018

Commits on Jan 31, 2018

  1. attempt to fix (catch) some pretty weird stacker issues that result i… 

    …n different

shapes being merged together
    @keflavich
    keflavich committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    f7681c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Merge remote-tracking branch 'upstream/master' into stacker_fixes

    @keflavich
    keflavich committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    6730f88 View commit details
    Browse the repository at this point in the history

  2. if the shifts are all in one direction, only pad in that direction

    @keflavich
    keflavich committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    e6729de View commit details
    Browse the repository at this point in the history

  3. addendum to previous: should be symmetric for both neg/pos

    @keflavich
    keflavich committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    fa9e76a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. swap neg shift / pos shift, because we want stuff before for the neg 

    shift and after for the pos shift
    @keflavich
    keflavich committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    2db40cf View commit details
    Browse the repository at this point in the history

  2. add a test that will likely fail 

    (also, add vel_surface to the cube generator)
    @keflavich
    keflavich committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    d990f89 View commit details
    Browse the repository at this point in the history

  3. fix that borken test by setting the header correctly

    @keflavich
    keflavich committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    8f9d06c View commit details
    Browse the repository at this point in the history