Possible fixes to the stacking code #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n different shapes being merged together
shift and after for the pos shift
(also, add vel_surface to the cube generator)
keflavich
commented
Feb 7, 2018
| @@ -269,7 +276,10 @@ def stack_spectra(cube, velocity_surface, v0=None, | |||
|
|
|||
| all_shifted_spectra.extend([out for out in shifted_spectra]) | |||
|
|
|||
| stacked = stack_function(all_shifted_spectra, axis=0) | |||
| shifted_spectra_array = np.array(all_shifted_spectra) | |||
| assert shifted_spectra_array.ndim == 2 | |||
There was a problem hiding this comment.
Just for the record, this is to solve a different issue - I once encountered an empty or weirdly shaped all_shifted_spectra, and I want to prevent that. Obviously assertions are not that useful in production code, but it should make future related errors easier to trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @e-koch - the padding might be off. Testing underway...