Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ssh operations sync #796

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

xphoniex
Copy link

@xphoniex xphoniex commented Oct 7, 2022

This PR completes the work done in radicle-dev/radicle-keystore#38.

Once these two PRs are merged, cli tooling can be switched over to sync version with minimal change.

Signed-off-by: xphoniex [email protected]

@xphoniex xphoniex requested a review from a team as a code owner October 7, 2022 16:49
@FintanH
Copy link
Contributor

FintanH commented Oct 10, 2022

Do you want to fix the build errors before I review?

Copy link
Contributor

@FintanH FintanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me. Fixing the builds would be good so I can also run through the tests locally

@xphoniex
Copy link
Author

Do you want to fix the build errors before I review?

Hm... I looked into a few of them and they're not cause by my code e.g. this :

error: unnecessary closure used with `bool::then`
  --> git-ref-format/core/src/lit.rs:24:9
   |
24 |         (c.as_ref() == Self::NAME).then(|| Self::SELF)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------
   |                                    |
   |                                    help: use `then_some(..)` instead: `then_some(Self::SELF)`
   |
   = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

@FintanH
Copy link
Contributor

FintanH commented Oct 10, 2022

Right, I'm fixing those here #797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants