Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to ssh-agent in a sync way #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xphoniex
Copy link

Signed-off-by: xphoniex [email protected]

@FintanH
Copy link
Contributor

FintanH commented Sep 27, 2022

Is there a follow-up to this @xphoniex because thrussh doesn't supply sync functions?

@xphoniex
Copy link
Author

Yup, we have sync one here. Posted this as a draft here, for now.

@FintanH
Copy link
Contributor

FintanH commented Sep 27, 2022

Yup, we have sync one here. Posted this as a draft here, for now.

Ah, that's what that was! Good luck :) The amount of async ssh pain I've gone through has been an experience 🙏

lnk-cryptovec = "0.6.0"
lnk-thrussh-agent = { version = "0.1.0", optional = true, default-features = false }
lnk-thrussh-encoding = { version = "0.1.0", optional = true }
cryptovec = { version = "0.6.0", git = "https://github.com/radicle-dev/radicle-ssh" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to adjust the deny.toml with the new git sources.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants