Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove extensions, reference new stac-api-extensions repos instead #321

Merged
merged 8 commits into from
Aug 24, 2022
Merged

remove extensions, reference new stac-api-extensions repos instead #321

merged 8 commits into from
Aug 24, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

  • n/a

Proposed Changes:

  1. Remove version extension and reference new stac-api-extensions version spec instead.

PR Checklist:

  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner marked this pull request as draft July 30, 2022 20:23
@philvarner philvarner changed the title remove version extension, reference new stac-api-extensions repo instead remove extensions, reference new stac-api-extensions repos instead Jul 31, 2022
@philvarner philvarner marked this pull request as ready for review July 31, 2022 19:19
@philvarner
Copy link
Collaborator Author

@m-mohr @matthewhanson @cholmes this is ready for review now

@cholmes cholmes mentioned this pull request Aug 16, 2022
Closed
@philvarner
Copy link
Collaborator Author

@cholmes @m-mohr this incorporates browseable into the Core specification now.

I plan on going through in another round of edits to clarify and make consistent the difference between a foundation specification, an extension specification, and a conformance class.

cholmes
cholmes approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for all your amazing work on this @philvarner!

@cholmes
Copy link
Collaborator

cholmes commented Aug 17, 2022

(and I'm happy for any clarifications too - happy to take time to read those as well, but marked as approved since I'm sure those changes will be good).

@philvarner philvarner merged commit 76b6b2b into radiantearth:main Aug 24, 2022
@philvarner philvarner deleted the pv/move-version-extension branch August 24, 2022 00:27
kylebarron
kylebarron reviewed Aug 30, 2022
View reviewed changes
item-search/README.md
Comment on lines +294 to +298
- [Fields Extension](https://github.com/stac-api-extensions/fields/blob/main/README.mda)
- [Sort Extension](https://github.com/stac-api-extensions/sort/blob/main/README.mda)
- [Context Extension](https://github.com/stac-api-extensions/context/blob/main/README.mda)
- [Filter Extension](https://github.com/stac-api-extensions/filter/blob/main/README.mda)
- [Query Extension](https://github.com/stac-api-extensions/query/blob/main/README.mda)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these links broken intentionally or as a typo? The a at the end gives a 404 and you presumably want README.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all should be .md instead of .mda - Not sure what happened there @philvarner

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably added the a with vim to one, and copied it everywhere else. Will fix.

kylebarron
kylebarron reviewed Aug 30, 2022
View reviewed changes
ogcapi-features/README.md
Comment on lines +324 to +330
- [Transaction Extension](https://github.com/stac-api-extensions/transaction/blob/main/README.mda)
- [Items and Collections API Version Extension](https://github.com/stac-api-extensions/version/blob/main/README.mda)
- [Fields Extension](https://github.com/stac-api-extensions/fields/blob/main/README.mda)
- [Sort Extension](https://github.com/stac-api-extensions/sort/blob/main/README.mda)
- [Context Extension](https://github.com/stac-api-extensions/context/blob/main/README.mda)
- [Filter Extension](https://github.com/stac-api-extensions/filter/blob/main/README.mda)
- [Query Extension](https://github.com/stac-api-extensions/query/blob/main/README.mda)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto these links are all broken

@kylebarron kylebarron mentioned this pull request Aug 30, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron left review comments

@cholmes cholmes cholmes approved these changes

@m-mohr m-mohr Awaiting requested review from m-mohr

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philvarner @cholmes @m-mohr @kylebarron