-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api/nonfungibles): fork pallet nfts #382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It caused a bit of confusion that you added v1.15 while pop node is on 1.14.
I compared the changes made from v1.14 and stable, and only sp-std
has been replaced for alloc
which is the case here as well and won't cause an issue.
Left a few nitpicks but the rest is all good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diffed with v1.15 and the only changes are the manifests and then source code formatting.
Only required change for me is attribution - setting the authors correctly.
c69dd85
to
b9fe4d8
Compare
Description
Fork of pallet-nfts v1.15.0 for the implementation of pallet-api/non-fungibles: #339.
Only changes I made is the
Cargo.toml
to update it consistent with other pallets.