Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nfts): add nonfungibles runtime implementation #339

Open
wants to merge 18 commits into
base: chungquantin/chore-pallet_nfts
Choose a base branch
from

test(nonfungibles): add tests and remove collection owner read

83e8122
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

feat(nfts): add nonfungibles runtime implementation #339

test(nonfungibles): add tests and remove collection owner read
83e8122
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 21, 2024 in 0s

clippy

23 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 23
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 70 in pallets/nfts/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

constants have by default a `'static` lifetime

warning: constants have by default a `'static` lifetime
  --> pallets/nfts/src/lib.rs:70:24
   |
70 | pub const LOG_TARGET: &'static str = "runtime::nfts";
   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
   = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default

Check warning on line 16 in runtime/testnet/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
  --> runtime/testnet/build.rs:1:1
   |
1  | / #[cfg(all(feature = "std", feature = "metadata-hash"))]
2  | | fn main() {
3  | |     substrate_wasm_builder::WasmBuilder::init_with_defaults()
4  | |         .enable_metadata_hash("PAS", 10)
...  |
15 | | #[cfg(not(feature = "std"))]
16 | | fn main() {}
   | |____________^
   |
   = note: requested on the command line with `-W missing-docs`

Check warning on line 16 in runtime/devnet/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
  --> runtime/devnet/build.rs:1:1
   |
1  | / #[cfg(all(feature = "std", feature = "metadata-hash"))]
2  | | fn main() {
3  | |     substrate_wasm_builder::WasmBuilder::init_with_defaults()
4  | |         .enable_metadata_hash("PAS", 10)
...  |
15 | | #[cfg(not(feature = "std"))]
16 | | fn main() {}
   | |____________^
   |
   = note: requested on the command line with `-W missing-docs`

Check warning on line 125 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for an associated function

warning: missing documentation for an associated function
   --> runtime/common/src/lib.rs:125:3
    |
125 |         pub fn is_superset(s: &ProxyType, o: &ProxyType) -> bool {
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/common/src/lib.rs:76:2
   |
76 | /     parameter_types! {
77 | |         // One storage item; key size 32, value size 8; .
78 | |         pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | |         // Additional storage item size of 33 bytes.
...  |
85 | |         pub const MaxPending: u16 = 32;
86 | |     }
   | |_____^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/common/src/lib.rs:76:2
   |
76 | /     parameter_types! {
77 | |         // One storage item; key size 32, value size 8; .
78 | |         pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | |         // Additional storage item size of 33 bytes.
...  |
85 | |         pub const MaxPending: u16 = 32;
86 | |     }
   | |_____^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/common/src/lib.rs:76:2
   |
76 | /     parameter_types! {
77 | |         // One storage item; key size 32, value size 8; .
78 | |         pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | |         // Additional storage item size of 33 bytes.
...  |
85 | |         pub const MaxPending: u16 = 32;
86 | |     }
   | |_____^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/common/src/lib.rs:76:2
   |
76 | /     parameter_types! {
77 | |         // One storage item; key size 32, value size 8; .
78 | |         pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | |         // Additional storage item size of 33 bytes.
...  |
85 | |         pub const MaxPending: u16 = 32;
86 | |     }
   | |_____^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/common/src/lib.rs:76:2
   |
76 | /     parameter_types! {
77 | |         // One storage item; key size 32, value size 8; .
78 | |         pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | |         // Additional storage item size of 33 bytes.
...  |
85 | |         pub const MaxPending: u16 = 32;
86 | |     }
   | |_____^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/common/src/lib.rs:76:2
   |
76 | /     parameter_types! {
77 | |         // One storage item; key size 32, value size 8; .
78 | |         pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | |         // Additional storage item size of 33 bytes.
...  |
85 | |         pub const MaxPending: u16 = 32;
86 | |     }
   | |_____^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 52 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
  --> runtime/common/src/lib.rs:52:1
   |
52 | pub const fn deposit(items: u32, bytes: u32) -> Balance {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 49 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a constant

warning: missing documentation for a constant
  --> runtime/common/src/lib.rs:49:1
   |
49 | pub const MICROUNIT: Balance = UNIT / 1_000_000; // 10_000
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 48 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a constant

warning: missing documentation for a constant
  --> runtime/common/src/lib.rs:48:1
   |
48 | pub const MILLIUNIT: Balance = UNIT / 1_000; // 10_000_000
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 46 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a constant

warning: missing documentation for a constant
  --> runtime/common/src/lib.rs:46:1
   |
46 | pub const UNIT: Balance = 10_000_000_000; // 10 decimals
   | ^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 31 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a constant

warning: missing documentation for a constant
  --> runtime/common/src/lib.rs:31:1
   |
31 | pub const DAYS: BlockNumber = HOURS * 24;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 30 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a constant

warning: missing documentation for a constant
  --> runtime/common/src/lib.rs:30:1
   |
30 | pub const HOURS: BlockNumber = MINUTES * 60;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 29 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a constant

warning: missing documentation for a constant
  --> runtime/common/src/lib.rs:29:1
   |
29 | pub const MINUTES: BlockNumber = 60_000 / (MILLISECS_PER_BLOCK as BlockNumber);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 22 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a constant

warning: missing documentation for a constant
  --> runtime/common/src/lib.rs:22:1
   |
22 | pub const SLOT_DURATION: u64 = MILLISECS_PER_BLOCK;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 137 in runtime/common/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
   --> runtime/common/src/lib.rs:1:1
    |
1   | / #![cfg_attr(not(feature = "std"), no_std)]
2   | | use frame_support::weights::{constants::WEIGHT_REF_TIME_PER_SECOND, Weight};
3   | | // Cumulus types re-export
4   | | // These types are shared between the devnet and testnet runtimes
...   |
136 | |     }
137 | | }
    | |_^
    |
    = note: requested on the command line with `-W missing-docs`

Check warning on line 38 in extension/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> extension/src/lib.rs:38:1
   |
38 | pub type ContractWeightsOf<T> = <T as pallet_contracts::Config>::WeightInfo;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 230 in extension/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
   --> extension/src/lib.rs:1:1
    |
1   | / #![cfg_attr(not(feature = "std"), no_std)]
2   | |
3   | | use core::marker::PhantomData;
...   |
229 | |     }
230 | | }
    | |_^
    |
    = note: requested on the command line with `-W missing-docs`

Check warning on line 83 in extension/src/functions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> extension/src/functions.rs:83:2
   |
83 |     PhantomData<(M, C, R, D, F, RC, E, L)>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 16 in runtime/mainnet/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
  --> runtime/mainnet/build.rs:1:1
   |
1  | / #[cfg(all(feature = "std", feature = "metadata-hash"))]
2  | | fn main() {
3  | |     substrate_wasm_builder::WasmBuilder::init_with_defaults()
4  | |         .enable_metadata_hash("DOT", 10)
...  |
15 | | #[cfg(not(feature = "std"))]
16 | | fn main() {}
   | |____________^
   |
   = note: requested on the command line with `-W missing-docs`