Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improvements and fixes #262

Merged
merged 18 commits into from
Sep 5, 2024

Conversation

evilrobot-01
Copy link
Collaborator

@evilrobot-01 evilrobot-01 commented Sep 4, 2024

Some improvements and fixes whilst reviewing #240.

See commit log for further details.

PS - sincere apologies about the last two commits, which were triggered by the fact that this PR tree has not been rebased on main. Rather than reformatting everything, to reformat again in the coming days, I think it made sense to bring in the nightly formatting and apply the fixes accordingly. We would have to tackle it imminently in any case. You should be able to select a range of commits when reviewing to exclude the last two.

@evilrobot-01 evilrobot-01 changed the title refactor: improvements and fixes test: improvements and fixes Sep 4, 2024
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean commits.

Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean overall, left a few comments for my concerns.

extension/src/functions.rs Show resolved Hide resolved
extension/src/lib.rs Show resolved Hide resolved
extension/src/lib.rs Show resolved Hide resolved
extension/src/decoding.rs Show resolved Hide resolved
@chungquantin chungquantin self-requested a review September 5, 2024 10:51
Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.78328% with 33 lines in your changes missing coverage. Please review.

Project coverage is 45.24%. Comparing base (e36c833) to head (1bd5060).

Files with missing lines Patch % Lines
extension/src/functions.rs 93.75% 0 Missing and 7 partials ⚠️
pallets/api/src/extension.rs 0.00% 6 Missing ⚠️
primitives/src/lib.rs 0.00% 6 Missing ⚠️
extension/src/tests.rs 92.06% 0 Missing and 5 partials ⚠️
extension/src/lib.rs 96.38% 0 Missing and 3 partials ⚠️
node/src/command.rs 0.00% 2 Missing ⚠️
runtime/devnet/src/config/xcm.rs 0.00% 2 Missing ⚠️
runtime/testnet/src/config/xcm.rs 0.00% 2 Missing ⚠️
@@                       Coverage Diff                        @@
##           chungquantin/extension-tests     #262      +/-   ##
================================================================
+ Coverage                         41.83%   45.24%   +3.40%     
================================================================
  Files                                39       40       +1     
  Lines                              3468     3698     +230     
  Branches                           3468     3698     +230     
================================================================
+ Hits                               1451     1673     +222     
- Misses                             1969     1971       +2     
- Partials                             48       54       +6     
Files with missing lines Coverage Δ
extension/src/decoding.rs 96.95% <100.00%> (-0.48%) ⬇️
extension/src/matching.rs 100.00% <100.00%> (ø)
extension/src/mock.rs 95.12% <100.00%> (+0.03%) ⬆️
pallets/api/src/fungibles/mod.rs 82.96% <100.00%> (ø)
runtime/devnet/src/config/api/mod.rs 0.00% <ø> (ø)
runtime/devnet/src/config/api/versioning.rs 61.19% <100.00%> (+0.29%) ⬆️
runtime/devnet/src/config/proxy.rs 0.00% <ø> (ø)
runtime/devnet/src/lib.rs 17.31% <ø> (ø)
runtime/testnet/src/config/proxy.rs 0.00% <ø> (ø)
runtime/testnet/src/extensions.rs 0.00% <ø> (ø)
... and 9 more

@evilrobot-01 evilrobot-01 merged commit 456b0cd into chungquantin/extension-tests Sep 5, 2024
10 checks passed
@evilrobot-01 evilrobot-01 deleted the frank/extension-tests branch September 5, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants