-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: generic extension unit testing #240
Conversation
Co-authored-by: chungquantin <[email protected]>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## frank/extension #240 +/- ##
===================================================
+ Coverage 35.84% 45.24% +9.39%
===================================================
Files 40 40
Lines 3270 3698 +428
Branches 3270 3698 +428
===================================================
+ Hits 1172 1673 +501
+ Misses 2039 1971 -68
+ Partials 59 54 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a partial review.
Looks great so far, left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!!! Really great coverage, the small test sizes made reviewing and understanding everything much easier.
Left some comments, but I can tell it's super close to being ready.
Test suite for modules in the generic extension crate: