Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve continuous integration + tweak to improve R CMD CHECK log #775

Merged
merged 38 commits into from
Sep 15, 2023

Commits on Sep 14, 2023

  1. initial testing

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    598a038 View commit details
    Browse the repository at this point in the history
  2. test pkgdown config

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    01c7c4a View commit details
    Browse the repository at this point in the history
  3. test

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9796ee8 View commit details
    Browse the repository at this point in the history
  4. Pkgdown tests (#1)

    * test pkgdown config
    
    * test
    olivroy authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    268f606 View commit details
    Browse the repository at this point in the history
  5. Revert " Pkgdown tests (#1)" (#2)

    This reverts commit 268f606.
    olivroy authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e465d6f View commit details
    Browse the repository at this point in the history
  6. Merge pull request #3 from olivroy/pkgdown

    Pkgdown
    olivroy authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9a5ba87 View commit details
    Browse the repository at this point in the history
  7. further tests

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a9d9982 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    311c48d View commit details
    Browse the repository at this point in the history
  9. Add config/needs/coverage.

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    aac8747 View commit details
    Browse the repository at this point in the history
  10. Cmd check fix (#5)

    * Update example of tm_layout to silence R CMD CHECK note.
    
    * Update tm_symbols example to silence R CMD CHECK NOTE
    
    * Fix R CMD CHECK on class
    
    * Add :: for non-base functions.
    
    * Remove :: or ::: usage for internal tmap functions.
    olivroy authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5df6369 View commit details
    Browse the repository at this point in the history
  11. Merged origin/master into wf

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    129544b View commit details
    Browse the repository at this point in the history
  12. Fix is mistake

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ae0ef89 View commit details
    Browse the repository at this point in the history
  13. Long lines in examples.

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    23002f2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e362b24 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    93c484b View commit details
    Browse the repository at this point in the history
  16. Use devtools

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    4cba006 View commit details
    Browse the repository at this point in the history
  17. Remove tic.R

    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9f0e06e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    b05dd6c View commit details
    Browse the repository at this point in the history
  19. [testing] Add try before failing tests to convert to warnings + add t…

    …ryCatch to fix a bug introduced by
    
    a713947
    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    93d2d94 View commit details
    Browse the repository at this point in the history
  20. [testing] Add placeholders for these functions as they will fail if s…

    …omeone tries to install the development version. To be deleted.
    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    f367432 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    220a507 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    63cb7f0 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    c5afc2c View commit details
    Browse the repository at this point in the history
  24. Add Condition to help capture the R CMD CHECK error.

      > # Example to illustrate the type of titles
      > tm_shape(World) +
      + 	tm_polygons(c("income_grp", "economy"), title = c("Legend Title 1", "Legend Title 2")) +
      + 	tm_layout(main.title = "Main Title",
      + 			  main.title.position = "center",
      + 			  main.title.color = "blue",
      + 			  title = c("Title 1", "Title 2"),
      + 			  title.color = "red",
      + 			  panel.labels = c("Panel Label 1", "Panel Label 2"),
      + 			  panel.label.color = "purple",
      + 			  legend.text.color = "brown")
      Deprecated tmap v3 code detected. Code translated to v4
      Warning: The 'title' argument of tm_layout is deprecated as of tmap 4.0. Please use tm_title instead.
      Warning: The 'main.title' argument of tm_layout is deprecated as of tmap 4.0. Please use tm_title instead.
      Error in if (is.ena(l$title)) l$title = paste0(names(v), attr(cls, "units")) :
        the condition has length > 1
      Calls: <Anonymous> ... with -> with.default -> eval -> eval -> apply_scale
    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    727bc66 View commit details
    Browse the repository at this point in the history
  25. Actually pass arguments to tm_scalebar and document it better.

    Propose an alternative to make it an error.
    olivroy committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7ca17f7 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    b468e40 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    3635112 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    79deee1 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Add note

    olivroy committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    9f89b5a View commit details
    Browse the repository at this point in the history
  2. Remove mentions to my branch.

    olivroy committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    b37e383 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    851d0a0 View commit details
    Browse the repository at this point in the history
  4. Address comments

    olivroy committed Sep 15, 2023
    2 Configuration menu
    Copy the full SHA
    9bac63d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d29660a View commit details
    Browse the repository at this point in the history
  6. copy news from CRAN

    olivroy committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    56df57b View commit details
    Browse the repository at this point in the history
  7. rename to md

    olivroy committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    c423868 View commit details
    Browse the repository at this point in the history
  8. use devtools style for news

    olivroy committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    34b378a View commit details
    Browse the repository at this point in the history
  9. fix in news after replace all

    olivroy committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    5be6f02 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    31323c3 View commit details
    Browse the repository at this point in the history