Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
olivroy committed Sep 15, 2023
1 parent 851d0a0 commit 9bac63d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions R/step2_helper_data.R
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,7 @@ getdts = function(aes, unm, p, q, o, dt, shpvars, layer, mfun, args, plot.order)
check_fun = paste0("tmapValuesCheck_", unm)
if (!do.call(check_fun, list(x = val1))) {
# to do: add "layer" name e.g. tm_fill is still "polygons" and not "fill"
warning("Visual values used for the variable, \"", unm, "\" of layer function \"tm_", layer[1], "\" are incorrect.", call. = FALSE)
warning("This error was converted to a warning for testing.")
return(NULL)
stop("Visual values used for the variable, \"", unm, "\" of layer function \"tm_", layer[1], "\" are incorrect.", call. = FALSE)
}

val1 = do.call(sfun, list(x = val1, scale = o$scale))
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ pak::pak("r-tmap/tmap")

# Or from r-universe
options(repos = c(
janmarvin = 'https://r-tmao.r-universe.dev',
tmap = 'https://r-tmao.r-universe.dev',

This comment has been minimized.

Copy link
@JanMarvin

JanMarvin Sep 19, 2023

oh thats me 😊 and I spotted a typo: tmao

This comment has been minimized.

Copy link
@olivroy

olivroy Sep 19, 2023

Author Contributor
CRAN = 'https://cloud.r-project.org'))
install.packages('tmap')
```
Expand Down

0 comments on commit 9bac63d

Please sign in to comment.