Provide way to register extra packages for revdep checks #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires r-lib/revdepcheck#352 to work Fixes #1610
DavisVaughan
approved these changes
Jan 19, 2023
|
|
||
| if (is_rstudio_pkg) { | ||
| if (length(extra) > 1) { | ||
| extra_code <- paste0(deparse(extra), collapse = "") |
There was a problem hiding this comment.
I had to run this locally to figure out what it did 😅
There was a problem hiding this comment.
Can it just be deparse(extra)?
extra <- letters[1:3]
identical(deparse(extra), paste0(deparse(extra), collapse = ""))
#> [1] TRUEThere was a problem hiding this comment.
Probably would be fine here, but it's safer to always collapse into a single string:
extra <- paste0("longpackagename", letters[1:10])
length(deparse(extra))
#> [1] 3Created on 2023-01-24 with reprex v2.0.2
|
|
||
| test_that("construct correct revdep bullet", { | ||
| create_local_package() | ||
| env <- env(release_extra_revdeps = function() c("waldo", "testthat")) |
There was a problem hiding this comment.
I assume this would have failed to give the right answer if it returned 1 character string instead of 2 because of that length() > 1 bug 😬
Co-authored-by: Davis Vaughan <[email protected]>
lionel-
approved these changes
Jan 20, 2023
Co-authored-by: Lionel Henry <[email protected]>
#Conflicts: # NEWS.md
jennybc
approved these changes
Jan 24, 2023
|
|
||
| if (is_rstudio_pkg) { | ||
| if (length(extra) > 1) { | ||
| extra_code <- paste0(deparse(extra), collapse = "") |
There was a problem hiding this comment.
Can it just be deparse(extra)?
extra <- letters[1:3]
identical(deparse(extra), paste0(deparse(extra), collapse = ""))
#> [1] TRUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires r-lib/revdepcheck#352 to work
Fixes #1610