Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customise list of packages in revdep check in use_release_issue() #1610

Closed
hadley opened this issue Mar 14, 2022 · 2 comments · Fixed by #1745
Closed

Customise list of packages in revdep check in use_release_issue() #1610

hadley opened this issue Mar 14, 2022 · 2 comments · Fixed by #1745
Labels
feature a feature request or enhancement release 🛫 tidy ✨ tools for the tidyverse team

Comments

@hadley
Copy link
Member

hadley commented Mar 14, 2022

e.g. waldo needs pkgs <- union(devtools::revdep("testthat"), devtools::revdep("waldo")) because most of the uses are via testthat.
@jennybc jennybc added the tidy ✨ tools for the tidyverse team label May 20, 2022
@hadley hadley added the feature a feature request or enhancement label Jan 17, 2023
@hadley hadley changed the title Someway to customise list of packages in revdep check in use_release_issue() Customise list of packages in revdep check in use_release_issue() Jan 18, 2023
@hadley hadley added this to the v2.2.0 milestone Jan 18, 2023
@hadley
Copy link
Member Author

hadley commented Jan 19, 2023

With r-lib/revdepcheck#352, this becomes revdepcheck::cloud_check(revdep_packages = revdepcheck::cran_revdeps(c("testthat", "waldo"))

@hadley
Copy link
Member Author

hadley commented Jan 19, 2023

And now revdepcheck::cloud_check(extra_revdeps = "testthat").

hadley added a commit that referenced this issue Jan 19, 2023
@hadley
Provide way to register extra packages for revdep checks
7a608f5 
Requires r-lib/revdepcheck#352 to work

Fixes #1610
@hadley hadley mentioned this issue Jan 19, 2023
Merged
@hadley hadley closed this as completed in 5ebd15a Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement release 🛫 tidy ✨ tools for the tidyverse team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide way to register extra packages for revdep checks r-lib/usethis
2 participants
@hadley @jennybc