Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LazyData to match new CRAN check #1404

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Fix LazyData to match new CRAN check #1404

merged 4 commits into from
Apr 13, 2021

Conversation

malcolmbarrett
Copy link
Collaborator

I'm also seeing #1403. Assuming this needs to be dealt with, this PR moves setting LazyData: true from use_description_defaults() to use_data()

Fixes #1403

@malcolmbarrett malcolmbarrett changed the title Fix lazy data Fix LazyData to match new CRAN check Mar 27, 2021
@malcolmbarrett malcolmbarrett mentioned this pull request Mar 29, 2021
Merged
@hadley
Copy link
Member

hadley commented Apr 12, 2021

Looks good, thanks! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@malcolmbarrett
Copy link
Collaborator Author

Done, thanks! I also realized the output in the README needed to be updated to match this change, so I knit that, as well.

@hadley hadley merged commit 753f04d into r-lib:master Apr 13, 2021
@malcolmbarrett malcolmbarrett deleted the fix_lazy_data branch April 13, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LazyData should only be set when data directory is present
2 participants
@malcolmbarrett @hadley