Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LazyData from !new #105

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Conversation

malcolmbarrett
Copy link
Contributor

This PR removes LazyData from the DESCRIPTION generated by the !new command and updates the expectations in related tests.

See also r-lib/usethis#1404

Closes #104

@gaborcsardi
Copy link
Member

Thanks! Can you please add a bullet point to the NEWS.md?

@codecov-io
Copy link

Codecov Report

Merging #105 (a717c68) into master (1a9af2d) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a717c68 differs from pull request most recent head c895342. Consider uploading reports for the commit c895342 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   98.89%   98.89%   -0.01%     
==========================================
  Files          18       18              
  Lines        1086     1085       -1     
==========================================
- Hits         1074     1073       -1     
  Misses         12       12              
Impacted Files Coverage Δ
R/description.R 97.64% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a9af2d...c895342. Read the comment docs.

@malcolmbarrett
Copy link
Contributor Author

updated!

@gaborcsardi
Copy link
Member

Great, thanks a lot!

@gaborcsardi gaborcsardi merged commit c21fa69 into r-lib:master Apr 2, 2021
@malcolmbarrett malcolmbarrett deleted the remove_lazy_data branch April 2, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyData - remove from default fields
3 participants