Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force = TRUE no longer force recompilation #93

Closed
lionel- opened this issue Dec 2, 2018 · 7 comments · Fixed by #202
Closed

force = TRUE no longer force recompilation #93

lionel- opened this issue Dec 2, 2018 · 7 comments · Fixed by #202
Labels
feature a feature request or enhancement

Comments

@lionel-
Copy link
Member

lionel- commented Dec 2, 2018

Pre-devtools 2, force = TRUE would force a full recompilation. Now I see:

Re-compiling purrr
─  installing *source* package ‘purrr’ ...
   ** libs
   make: Nothing to be done for `all'.

Forcing recompilation is useful for things like seeing compilation warnings again, or rebuilding the .so on a different computer, or with different Makevars.

@jimhester
Copy link
Member

This was changed by #81, which @hadley wanted for roxygen. But I believe that changed did not satisfy the issue in roxygen, so likely this will end up getting changed again...

@hadley
Copy link
Member

hadley commented Dec 3, 2018

@lionel- can't you use compile = TRUE?

@lionel-
Copy link
Member Author

lionel- commented Dec 3, 2018

Sorry I was confused. I'm using recompile = TRUE, not force =, which got deprecated in favour of compile =. This is not even the right package, I should have posted in pkgload.

@lionel- lionel- closed this as completed Dec 3, 2018
@lionel-
Copy link
Member Author

lionel- commented Dec 3, 2018

Though devtools::load_all(compile = TRUE) does not force a recompilation actually. Am I still missing something?

@lionel- lionel- reopened this Dec 4, 2018
@lionel-
Copy link
Member Author

lionel- commented Dec 4, 2018

Should this be transferred at pkgload?

@lionel-
Copy link
Member Author

lionel- commented Feb 26, 2019

Am I the only one who needs to force recompilation of binaries? Perhaps there's something specific to my workflow?

@jimhester
Copy link
Member

I always use an explicit devtools::clean_dll() + devtools::load_all() to do a clean recompile.

I think the current behavior is broken and likely this will go back to how it used to be, but I was waiting for the roxygen issues to get sorted out before committing to a path.

@jimhester jimhester transferred this issue from r-lib/pkgbuild Mar 20, 2019
@jimhester jimhester added the feature a feature request or enhancement label Apr 3, 2020
lionel- added a commit that referenced this issue May 30, 2022
lionel- added a commit that referenced this issue May 30, 2022
lionel- added a commit that referenced this issue Jun 1, 2022
Closes #93

Co-authored-by: Hadley Wickham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants