Compile #81
Merged
Compile #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhester
reviewed
Oct 24, 2018
jimhester
reviewed
Oct 24, 2018
R/load.r
Outdated
| pkgbuild::compile_dll(path, force = TRUE, quiet = quiet) | ||
| } else if (identical(compile, NA)) { | ||
| pkgbuild::compile_dll(path, quiet = quiet) | ||
| } else if (isFALSE(compile)) { |
There was a problem hiding this comment.
isFALSE() is only available in R >= 3.5, so we would need an implementation of it in utils or a backport.
There was a problem hiding this comment.
I used identical() which should be fine for this usage.
jimhester
reviewed
Oct 24, 2018
jimhester
reviewed
Oct 24, 2018
jimhester
reviewed
Oct 24, 2018
|
@jimhester should be good for another review now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #80. I'm open to ideas for testing