Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should test()/check() warn if missing developer dependencies? #1970

Closed
hadley opened this issue Jan 19, 2019 · 8 comments
Closed

Should test()/check() warn if missing developer dependencies? #1970

hadley opened this issue Jan 19, 2019 · 8 comments
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Jan 19, 2019

And hint to use install_dev_deps()

@jimhester
Copy link
Member

jimhester commented Jan 20, 2019

Maybe load_all() as well, I had to make this same suggestion to many people at the dev day too.

@jimhester jimhester added the feature a feature request or enhancement label Jan 20, 2019
@hadley
Copy link
Member Author

hadley commented Jan 20, 2019

Maybe we should have a pkg_sitrep() too?

@jennybc
Copy link
Member

jennybc commented Apr 8, 2019

This came up in today's group meeting and concluded with what I now see @hadley had already said: we need a sitrep-type of function that reports readiness for package development, in general and with respect to the current package/project.

Does this belong in devtools or usethis? I suspect devtools? Once it exists, it is conceivable that usethis::create_from_github() should call this if the newly created project is a package.

@jimhester
Copy link
Member

Ok I added a new function pkg_sitrep(). This is how it looks now if you have all the detectable problems.

I think we should have people run devtools::pkg_sitrep() as the first thing they do when starting working on a package during the dev day.

Screen Shot 2019-09-04 at 1 13 43 PM

@jennybc
Copy link
Member

jennybc commented Sep 4, 2019

Looks awesome (based on glimpse above)!

What you think of calling it dev_sitrep()?

@jimhester
Copy link
Member

I am fine with it, I called it pkg_siterep() only because @hadley mentioned that name in #1970 (comment). But dev_sitrep() is probably better.

@jennybc
Copy link
Member

jennybc commented Sep 4, 2019

pkg_sitrep() feels like it might be reporting on a specific package (probably the "current one", if well-defined) whereas dev_sitrep() somehow feels more related to "am I ready for package development?"

@lock
Copy link

lock bot commented Mar 10, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants