Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return success for has_devel()? #73

Closed
batpigandme opened this issue Apr 22, 2019 · 1 comment
Closed

Return success for has_devel()? #73

batpigandme opened this issue Apr 22, 2019 · 1 comment

Comments

@batpigandme
Copy link
Contributor

Possibly an issue for whattheyforgot, but I was confused by silence = success when running devtools::has_devel()for system prep (or perhaps it should be pkgbuild::check_build_tools() based on the usethis vignette here):
https://whattheyforgot.org/set-up-an-r-dev-environment.html#verify-system-prep
https://github.com/jennybc/what-they-forgot/blob/ec7696b21af2110e7f81262fd3cda8fd24c62e32/14_system-prep-for-build.Rmd#L47

Counterarguments:

  • It does say:

    If this function runs without error then congratulations, your R installation is properly set up!

  • I'm guessing there are good reasons for a successful check to be silent.

Possible alternative

  • Create a devel_sitrep() type function (probably in usethis) that is explicitly for returning messages about devel-readiness? (cc @jennybc — I browsed GH issues, but I might have missed something already present)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant