Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advice for text + line + col + file hyperlink #670

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 15, 2024

Until #601 is fixed.

I tried looking into fixing it, but couldn't figure it out due to the regexp.

I added this clarification about line and col being numeric, because I was once extracting regexp and forgot to convert to numeric, and they get ignored.

# silently fails
cli::style_hyperlink(
  text = "R profile at line 5",
  url = "file://~/.Rprofile",
  params = c(line = "5", col = "1")
)

Edit 2: from posit-dev/positron#4968 (reply in thread) it is also better to use absolute paths as opposed to relative paths for this syntax

@olivroy
Copy link
Contributor Author

olivroy commented Oct 9, 2024

@gaborcsardi It seems that this syntax doesn't work in Positron? Should an issue be open there, or is that something that can be fixed with cli?

edit: Apparently, this is a newly introduced Positron bug. posit-dev/positron#4968

I changed list() to c() like it is in warn_roxy()

https://github.com/r-lib/roxygen2/blob/9652d15221109917d46768e836eaf55e33c21633/R/utils-warn.R#L24-L34

It seems that this works correctly in Positron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant