-
cli::style_hyperlink(
"file","file://NEWS.md", list(line = 6, col = 2)
)Try to click on this link generated from this. It works in RStudio. (with NEWS.md being an existing file) On Windows, it opens the following (non-existing) file Edit: changed to 2 leading slashes as this is what is actually supported in RStudio. Edit2: This seems to work. cli::style_hyperlink(
"file","file://NEWS.md", c(line = 6, col = 2)
) |
Beta Was this translation helpful? Give feedback.
Replies: 8 comments 9 replies
-
|
I am also seeing this (file hyperlinks no longer working) in: Positron Version: 2024.10.0 (Universal) build 14 |
Beta Was this translation helpful? Give feedback.
-
|
I'm seeing this in developer console: |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for looking into this. FWIW, I edited my post. The supported syntax is with 2 leading Do you think this bug is a Positron or cli bug? |
Beta Was this translation helpful? Give feedback.
-
|
This commit looks likely to be the culprit (but this should be taken with a big grain of salt): 833a9b3#diff-b68e95d8ebaec9fc38aad38c3df9f68d2951bc577b3de330bf552bcafa7f1d34R619 |
Beta Was this translation helpful? Give feedback.
-
|
I think it's a positron bug. |
Beta Was this translation helpful? Give feedback.
-
|
By the time there's an attempt to open the file, it has become 
Screenshot is with Positron Version: 2024.10.0 (Universal) build 14 |
Beta Was this translation helpful? Give feedback.
-
|
I am not seeing a problem with this clickable link: cli::cli_text("{.file NEWS.md}")so that suggests there may be an interaction between positron changes and this style of file url |
Beta Was this translation helpful? Give feedback.
-
|
Here's the working file hyperlink, produce via inline markup:
So it's using an absolute path that starts with |
Beta Was this translation helpful? Give feedback.
-
|
Based on what I see here in cli's internal docs, I'm not sure https://github.com/r-lib/cli/blob/main/R/ansi-hyperlink.R |
Beta Was this translation helpful? Give feedback.
-
|
Due to r-lib/cli#601, I have used this syntax as a workaround. It is used in roxygen2's code to generate warnings with clickable links at file line numbers + different display names. I have sprinkled this in my own code and packages I contribute to like lintr and goodpractice (maybe pkgdown too) https://cli.r-lib.org/reference/links.html?q=.href#files |
Beta Was this translation helpful? Give feedback.
-
|
After a bit more investigation, I changed my internal code to using cli::style_hyperlink(
"file","file://NEWS.md", c(line = 6, col = 2)
)like it is in roxygen2 in I simulated a roxygen2 warning (i.e. add an empty |
Beta Was this translation helpful? Give feedback.
-
|
So is this an accurate summary of where we are?
If this is the case, then I guess there's no follow up needed (?). |
Beta Was this translation helpful? Give feedback.
-
|
I think this is right. From a github search for https://github.com/rossellhayes/wtfn/blob/f223d4926e8590b043181b9c103a2fdaaf1dace1/R/get_wtfn_status.R#L133 Is there a way to add a test in Positron to make sure the correct syntax (with params as vector) doesn't break in the future? |
Beta Was this translation helpful? Give feedback.
-
|
@olivroy something that puzzles me. Using > dput(cli::style_hyperlink(
+ "file","file://NEWS.md", list(line = 6, col = 2)
+ ))
structure("\033]8;line = 6:col = 2;file://NEWS.md\afile\033]8;;\a", class = c("cli_ansi_string",
"ansi_string", "character"))
> dput(cli::style_hyperlink(
+ "file","file://NEWS.md", c(line = 6, col = 2)
+ ))
structure("\033]8;line = 6:col = 2;file://NEWS.md\afile\033]8;;\a", class = c("cli_ansi_string",
"ansi_string", "character")) |
Beta Was this translation helpful? Give feedback.
-
|
I don't know.. I mis-diagnosed the issue in this case. It seems that the syntax works for full paths, but not for relative paths... # this works
cli::style_hyperlink(
"file","file://C:/users/royo/documents/projects/infrastructure/NEWS.md", c(line = 6, col = 2)
)
# this doesn't
cli::style_hyperlink(
"file","file://NEWS.md", c(line = 6, col = 2)
)Both work in RStudio.. |
Beta Was this translation helpful? Give feedback.
-
|
I did a lot of research on file hyperlinks when working on #2413. I think the best outside authority to consult is RFC 8089 The "file" URI Scheme: https://datatracker.ietf.org/doc/html/rfc8089 I don't really see any support for relative paths in such links. Leading up to now, I think it's fair to say that cli hyperlinks and RStudio support of said hyperlinks sort of co-evolved to perhaps handle nonstandard hyperlinks or to go beyond the standard. So this may not be an area where Positron implements 100% of what RStudio does. Positron will likely stick close to the standard. My guess is that, if you are creating a hyperlink yourself, your code should look like this to have the best chance of working in multiple IDEs, across multiple OSes, over time: Key points:
cli::style_hyperlink(
"file","file:///C:/users/royo/documents/projects/infrastructure/NEWS.md", c(line = 6, col = 2)
) |
Beta Was this translation helpful? Give feedback.
-
|
Thank you very much for taking the time! |
Beta Was this translation helpful? Give feedback.
I did a lot of research on file hyperlinks when working on #2413. I think the best outside authority to consult is RFC 8089 The "file" URI Scheme:
https://datatracker.ietf.org/doc/html/rfc8089
I don't really see any support for relative paths in such links. Leading up to now, I think it's fair to say that cli hyperlinks and RStudio support of said hyperlinks sort of co-evolved to perhaps handle nonstandard hyperlinks or to go beyond the standard. So this may not be an area where Positron implements 100% of what RStudio does. Positron will likely stick close to the standard.
My guess is that, if you are creating a hyperlink yourself, your code should look like this to have the best chance …