Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthentiCode sign launcher, uninstaller #614

Merged
merged 14 commits into from
Apr 8, 2020
Merged

AuthentiCode sign launcher, uninstaller #614

merged 14 commits into from
Apr 8, 2020

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Mar 31, 2020

Refactors NSIS installers and ANT to provide properly sign .exe files:

  • Centralizes and consolidates ant signing code to signing.xml
  • Adds signing steps for uninstall.exe, qz-tray.exe
  • Removes NSIS built-in "Uninstall" section, uses masqueraded "Install" instead
  • Changes all ant messages from default warning level to info level.
  • Renamed apple codesigning targets to avoid confusion

Closes #593

@tresf tresf added this to the 2.1.1 milestone Mar 31, 2020
@tresf tresf requested a review from klabarge March 31, 2020 20:27
@tresf
Copy link
Contributor Author

tresf commented Apr 8, 2020

Tested on Windows XP, Windows 7, Windows 10. All pass. In doing so, found some lingering launcher that weren't be cleaned up properly 5e4624e, f2655ff.

@tresf
Copy link
Contributor Author

tresf commented Apr 8, 2020

Tested on Ubuntu 18.04, passes.

Tested on MacOS 10.15 and it fails with the following message on the HTTP about page:

java.lang.NoClassDefFoundError: jssc/SerialNativeInterface
	at qz.common.SecurityInfo.getLibVersions(Unknown Source)
	at qz.common.AboutInfo.libraries(Unknown Source)
	at qz.common.AboutInfo.gatherAbout(Unknown Source)
	at qz.ws.HttpAboutServlet.generateHtmlResponse(Unknown Source)
	at qz.ws.HttpAboutServlet.doGet(Unknown Source)
        ...

I suspect something's gone wrong with the mac code signing steps.

@tresf
Copy link
Contributor Author

tresf commented Apr 8, 2020

I suspect something's gone wrong with the mac code signing steps.

Fixed via 59f0f7a. Tested macOS 10.8, 10.15, passing.

Final step is checking if notarization passes, then we can merge.

@tresf tresf merged commit 35ea73f into master Apr 8, 2020
@tresf tresf deleted the ant-sign branch April 8, 2020 21:05
@tresf tresf mentioned this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticode Sign qz-tray.exe, uninstall.exe
2 participants