Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticode Sign qz-tray.exe, uninstall.exe #593

Closed
tresf opened this issue Feb 25, 2020 · 1 comment · Fixed by #614
Closed

Authenticode Sign qz-tray.exe, uninstall.exe #593

tresf opened this issue Feb 25, 2020 · 1 comment · Fixed by #614
Assignees

Comments

@tresf
Copy link
Contributor

tresf commented Feb 25, 2020

I thought I had an open item for this... but apparently not...
We need to sign all exe's that we distribute. Partial support was written in #535 but it was closed as wontfix since the patch wasn't effective and the changes didn't address the uninstaller.

  • Sign the qz-tray.exe
  • Sign the uninstall.exe

Since ant doesn't handle blank values well we have target-specific logic to handle authenticode. I feel this code will become redundant when signing three separate files so I'm asking @bberenz to help write a reusable ant target for this. :D

@tresf
Copy link
Contributor Author

tresf commented Mar 31, 2020

I'm asking @bberenz to help write a reusable ant target for this. :D

Reusable ant targets done via #614.

the patch wasn't effective and the changes didn't address the uninstaller.

As it turns out, the uninstall.exe cannot be signed because it's created and bundled into the installer by makensis and workarounds provided by NSIS aren't compatible with Linux or MacOS. New workaround published and available in #614.

@tresf tresf closed this as completed in #614 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants