QUnit.load is now called inside QUnit.start #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gh-1081 Before this patch, calling QUnit.load() (before or after QUnit.start) to run the test suite in non-browser environments.
| } else if ( !defined.document && !config.pageLoaded ) { | ||
|
|
||
| // Starts from Node even if .load was not previously called | ||
| QUnit.load(); |
There was a problem hiding this comment.
I'm assuming we'll refactor this later due to #1084.
There was a problem hiding this comment.
Yeah, it's not beautiful but it's a fix for now.
trentmwillis
approved these changes
Dec 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only in non-browser environments, avoiding breaking changes.
Closes gh-1081