Not 'loading' properly on Node #1081
Assignees
Labels
Type: Bug
Something isn't working right.
Comments
leobalter
added a commit
that referenced
this issue
Dec 14, 2016
Fixes gh-1081 Before this patch, calling QUnit.load() (before or after QUnit.start) to run the test suite in non-browser environments.
leobalter
added a commit
that referenced
this issue
Dec 14, 2016
Fixes gh-1081 Before this patch, calling QUnit.load() (before or after QUnit.start) to run the test suite in non-browser environments.
leobalter
added a commit
that referenced
this issue
Dec 14, 2016
Fixes gh-1081 Before this patch, calling QUnit.load() (before or after QUnit.start) to run the test suite in non-browser environments.
|
Will this be in a patch release (2.1.1)? Any ETA? |
|
Yes, this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to make this more friendly on Node.
@getify helped me finding this bug.
As you can see here, unless we call
QUnit.load()beforeQUnit.start(), QUnit won't run properly in Node.We need to make
QUnit.starta self method to load and start QUnit without calling anything else. This is the expected behavior reading the api docs.The good part is that we can remove any sights of 1.x warnings of QUnit.start along.
As I can't commit to any code today, I'm planning to fix this tomorrow - Dec 12 - in the evening (EST), high priority, unless someone wants to fix it before, please just add a comment here.
The text was updated successfully, but these errors were encountered: