Build: Update browserstack-runner to fix QUnit.todo support

It is hard to believe, but we actually never had a `QUnit.todo()`
test as part of the main index.html test suite that we run in browsers.

There were secondary tests that only run in Headless Chromium via
grunt-contrib-qunit, and CLI tests, but none that we run cross browser.

In commit 47576c1 I added test/main/each.js to index.html, not
realizing it was the first such case, and this broke the CI build for
all browsers.

* js-reporters 2.1 adds support for QUnit.todo in the adapter
  so that it correctly emits the `runEnd` event to count these toward
  `testCounts.todo` instead of toward `testCounts.failed`.
  qunitjs/js-reporters#140.

* browserstack-runner 0.9.5-qunitjs.1 updates its copy of js-reporters
  to this version, and also updates its error formatter to not print
  details for error objects from non-failed tests.

Fixes #1622.

.github/workflows/browsers-quick.yaml

@@ -28,6 +28,13 @@ jobs:
           npm ci
           npm run build
 
+      # To debug locally:
+      #
+      # ```
+      # $ export BROWSERSTACK_USERNAME="***"
+      # $ export BROWSERSTACK_KEY="***"
+      # $ BROWSERSTACK_JSON=build/browserstack-debug.json npm run browserstack
+      # ```
       - name: Tests
         run: npm run browserstack
         env:

build/browserstack-debug.json

@@ -0,0 +1,11 @@
+{
+  "test_framework": "qunit",
+  "test_path": ["test/index.html"],
+  "test_server_port": "8899",
+  "exit_with_fail": true,
+  "timeout": 600,
+  "browsers": [
+    "firefox_current",
+    "chrome_current"
+  ]
+}

package.json

@@ -53,7 +53,7 @@
     "@rollup/plugin-commonjs": "^18.0.0",
     "@rollup/plugin-node-resolve": "^11.2.1",
     "@rollup/plugin-replace": "^2.4.2",
-    "@qunitjs/browserstack-runner": "0.9.4-qunitjs.2",
+    "@qunitjs/browserstack-runner": "0.9.5-qunitjs.1",
     "coveralls": "^3.1.0",
     "eslint": "7.23.0",
     "eslint-config-jquery": "^3.0.0",

src/test.js

@@ -303,6 +303,13 @@ Test.prototype = {
 		module.stats.all += this.assertions.length;
 
 		for ( let i = 0; i < this.assertions.length; i++ ) {
+
+			// A failing assertion will counts toward the HTML Reporter's
+			// "X assertions, Y failed" line even if it was inside a todo.
+			// Inverting this would be similarly confusing since all but the last
+			// passing assertion inside a todo test should be considered as good.
+			// These stats don't decide the outcome of anything, so counting them
+			// as failing seems the most intuitive.
 			if ( !this.assertions[ i ].result ) {
 				bad++;
 				config.stats.bad++;
@@ -316,7 +323,9 @@ Test.prototype = {
 			incrementTestsRun( module );
 		}
 
-		// Store result when possible
+		// Store result when possible.
+		// Note that this also marks todo tests as bad, thus they get hoisted,
+		// and always run first on refresh.
 		if ( storage ) {
 			if ( bad ) {
 				storage.setItem( "qunit-test-" + moduleName + "-" + testName, bad );