Reporter: Recognise "Todo" tests from QUnit #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't previously done because versions that support this feature also have a jsreporters-compatible event emitter built-in, but this isn't always used (such as in browserstack-runner). So for completion support it here as well just in case. Ref qunitjs/qunit#1622.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Jun 6, 2021
It is hard to believe, but we actually never had a `QUnit.todo()` test as part of the main index.html test suite that we run in browsers. There were secondary tests that only run in Headless Chromium via grunt-contrib-qunit, and CLI tests, but none that we run cross browser. In commit -- I added test/main/each.js to index.html, not realizing it was the first such case, and this broke the CI build for all browsers. * js-reporters 2.1 adds support for QUnit.todo in the adapter so that it correctly emits the `runEnd` event to count these toward `testCounts.todo` instead of toward `testCounts.failed`. qunitjs/js-reporters#140. * browserstack-runner 0.9.5-qunitjs.1 updates its copy of js-reporters to this version, and also updates its error formatter to not print details for error objects from non-failed tests.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Jun 6, 2021
It is hard to believe, but we actually never had a `QUnit.todo()` test as part of the main index.html test suite that we run in browsers. There were secondary tests that only run in Headless Chromium via grunt-contrib-qunit, and CLI tests, but none that we run cross browser. In commit -- I added test/main/each.js to index.html, not realizing it was the first such case, and this broke the CI build for all browsers. * js-reporters 2.1 adds support for QUnit.todo in the adapter so that it correctly emits the `runEnd` event to count these toward `testCounts.todo` instead of toward `testCounts.failed`. qunitjs/js-reporters#140. * browserstack-runner 0.9.5-qunitjs.1 updates its copy of js-reporters to this version, and also updates its error formatter to not print details for error objects from non-failed tests.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Jun 7, 2021
It is hard to believe, but we actually never had a `QUnit.todo()` test as part of the main index.html test suite that we run in browsers. There were secondary tests that only run in Headless Chromium via grunt-contrib-qunit, and CLI tests, but none that we run cross browser. In commit 47576c1 I added test/main/each.js to index.html, not realizing it was the first such case, and this broke the CI build for all browsers. * js-reporters 2.1 adds support for QUnit.todo in the adapter so that it correctly emits the `runEnd` event to count these toward `testCounts.todo` instead of toward `testCounts.failed`. qunitjs/js-reporters#140. * browserstack-runner 0.9.5-qunitjs.1 updates its copy of js-reporters to this version, and also updates its error formatter to not print details for error objects from non-failed tests. Fixes #1622.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't previously done because versions that support this feature also have a jsreporters-compatible event emitter built-in, but this isn't always used (such as in browserstack-runner). So for completion support it here as well just in case.
Ref qunitjs/qunit#1622.