Skip to content

Commit

Permalink
fix bad bool check in action (bluesky-social#3885)
Browse files Browse the repository at this point in the history
* fix bad bool check in action

* add `fetch-depth` so we can get the commit hash

* `.env` should be in `.easignore` 🙃
  • Loading branch information
haileyok authored May 7, 2024
1 parent 92f6665 commit 790a9c4
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .easignore
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ web-build/
/ios/

# environment variables
.env
.env.*

# Firebase (Android) Google services
# INCLUDED: google-services.json
# INCLUDED: google-services.json
2 changes: 2 additions & 0 deletions .github/workflows/build-submit-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
- name: ⬇️ Checkout
uses: actions/checkout@v4
with:
fetch-depth: 5

- name: 🔧 Setup Node
uses: actions/setup-node@v4
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build-submit-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
- name: ⬇️ Checkout
uses: actions/checkout@v4
with:
fetch-depth: 5

- name: 🔧 Setup Node
uses: actions/setup-node@v4
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/bundle-deploy-eas-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-latest
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.ref }}-deploy
cancel-in-progress: true
cancel-in-progress: false
outputs:
fingerprint-is-different: ${{ steps.fingerprint-debug.outputs.fingerprint-is-different }}

Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
- name: 🕵️ Get the base commit
id: base-commit
run: |
if [ -z "${{ inputs.channel == 'production' }}" ]; then
if [ ${{ inputs.channel == 'production' }} ]; then
echo base-commit=$(git show-ref -s ${{ inputs.runtimeVersion }}) >> "$GITHUB_OUTPUT"
else
echo base-commit=${{ steps.last-successful-commit.base-commit }} >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -184,6 +184,8 @@ jobs:
- name: ⬇️ Checkout
uses: actions/checkout@v4
with:
fetch-depth: 5

- name: 🔧 Setup Node
uses: actions/setup-node@v4
Expand Down Expand Up @@ -255,6 +257,8 @@ jobs:
- name: ⬇️ Checkout
uses: actions/checkout@v4
with:
fetch-depth: 5

- name: 🔧 Setup Node
uses: actions/setup-node@v4
Expand Down
3 changes: 1 addition & 2 deletions src/lib/app-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export const IS_TESTFLIGHT = process.env.EXPO_PUBLIC_ENV === 'testflight'

// This is the commit hash that the current bundle was made from. The user can see the commit hash in the app's settings
// along with the other version info. Useful for debugging/reporting.
export const BUNDLE_IDENTIFIER =
process.env.EXPO_PUBLIC_BUNDLE_IDENTIFIER ?? 'dev'
export const BUNDLE_IDENTIFIER = process.env.EXPO_PUBLIC_BUNDLE_IDENTIFIER ?? ''

// This will always be in the format of YYMMDD, so that it always increases for each build. This should only be used
// for Statsig reporting and shouldn't be used to identify a specific bundle.
Expand Down

0 comments on commit 790a9c4

Please sign in to comment.