-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bad bool check in action #3885
Merged
Merged
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://social-app-pr-3885.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cosp8m021fec739dr360. |
|
The Pull Request introduced fingerprint changes against the base commit: 4fad18b Fingerprint diff[{"type":"file","filePath":".easignore","reasons":["easBuild"],"hash":"5bdc94c3fe1328896e713b6bb91ca43a6d62d09b"}] Generated by PR labeler 🤖 |
You mean remove it from ignore? |
gaearon
approved these changes
May 7, 2024
oops yea. remove from easignore, add to the build process. |
tkusano
pushed a commit
to tkusano/social-app
that referenced
this pull request
May 7, 2024
* fix bad bool check in action * add `fetch-depth` so we can get the commit hash * `.env` should be in `.easignore` 🙃
pfrazee
pushed a commit
that referenced
this pull request
May 20, 2024
* Update Japanese translations * Updated as PR on Plural is merged (#3882) * Feedback API (#3498) etc. * Improve localization marks (#3285) * Update Lightbox.tsx * Change strings for easier localization * Update DeleteAccount.tsx * Update LabelsOnMeDialog.tsx * Update FeedCard.tsx * Update index.tsx * Update LabelsOnMeDialog.tsx * Update index.tsx * Update FeedCard.tsx * Update SelfLabel.tsx * Update Hashtag.tsx * Update index.tsx * Update Hashtag.tsx * Update ChangeHandle.tsx * Update index.web.tsx * Update index.web.tsx * Update index.tsx * Remove unnecessary `<Trans>` tags * Update Drawer.tsx * Finnish translation update (#3755) * Update messages.po Translated new strings (GIF's etc) and cleaned up deprecated ones. * Update messages.po resolve conflict * Update messages.po removed double quotes. Thanks @lapanti * fix bad bool check in action (#3885) * fix bad bool check in action * add `fetch-depth` so we can get the commit hash * `.env` should be in `.easignore` 🙃 * Updated to follow #3285 etc. * The translation of 'place' and 'apply' of labels has been unified into '適用する'. * Fix translation of "repost" * Updated * Updated Japanese translation * Updated Japanese translation - #3816 * Fixed translations * Updated translation : #3995 * Updated Japanese translation * Updated Japanese translation (ref. #3962 #4028) * Updated Japanese translation * Updated Japanese translation * Updated Japanese translation --------- Co-authored-by: Minseo Lee <[email protected]> Co-authored-by: Jan-Olof Eriksson <[email protected]> Co-authored-by: Hailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.env
to.easignore
Regarding the last point, if we don't add this to the
.easignore
, it won't pick up our environment variables. Seeeas build:inspect --stage archive -p ios --output sampleBuildFiles