Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad bool check in action #3885

Merged
merged 3 commits into from
May 7, 2024
Merged

fix bad bool check in action #3885

merged 3 commits into from
May 7, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented May 7, 2024

  • Don't cancel still-running bundle deploys if we merge another PR. Feels better to just let them run (this is for internal use only)
  • Replace a null check with what is supposed to just be an equality check
  • Always fetch some commits so that we can get the commit hash
  • Add .env to .easignore

Regarding the last point, if we don't add this to the .easignore, it won't pick up our environment variables. See eas build:inspect --stage archive -p ios --output sampleBuildFiles

Copy link

render bot commented May 7, 2024

Copy link

github-actions bot commented May 7, 2024

Old size New size Diff
6.88 MB 6.88 MB 0 B (0.00%)

Copy link

github-actions bot commented May 7, 2024

The Pull Request introduced fingerprint changes against the base commit: 4fad18b

Fingerprint diff
[{"type":"file","filePath":".easignore","reasons":["easBuild"],"hash":"5bdc94c3fe1328896e713b6bb91ca43a6d62d09b"}]

Generated by PR labeler 🤖

@gaearon
Copy link
Collaborator

gaearon commented May 7, 2024

Add .env to .easignore

You mean remove it from ignore?

@haileyok
Copy link
Contributor Author

haileyok commented May 7, 2024

oops yea. remove from easignore, add to the build process.

@haileyok haileyok merged commit 790a9c4 into main May 7, 2024
6 checks passed
tkusano pushed a commit to tkusano/social-app that referenced this pull request May 7, 2024
* fix bad bool check in action

* add `fetch-depth` so we can get the commit hash

* `.env` should be in `.easignore` 🙃
pfrazee pushed a commit that referenced this pull request May 20, 2024
* Update Japanese translations

* Updated as PR on Plural is merged (#3882)
* Feedback API (#3498)

etc.

* Improve localization marks (#3285)

* Update Lightbox.tsx

* Change strings for easier localization

* Update DeleteAccount.tsx

* Update LabelsOnMeDialog.tsx

* Update FeedCard.tsx

* Update index.tsx

* Update LabelsOnMeDialog.tsx

* Update index.tsx

* Update FeedCard.tsx

* Update SelfLabel.tsx

* Update Hashtag.tsx

* Update index.tsx

* Update Hashtag.tsx

* Update ChangeHandle.tsx

* Update index.web.tsx

* Update index.web.tsx

* Update index.tsx

* Remove unnecessary `<Trans>` tags

* Update Drawer.tsx

* Finnish translation update (#3755)

* Update messages.po

Translated new strings (GIF's etc) and cleaned up deprecated ones.

* Update messages.po

resolve conflict

* Update messages.po

removed double quotes. Thanks @lapanti

* fix bad bool check in action (#3885)

* fix bad bool check in action

* add `fetch-depth` so we can get the commit hash

* `.env` should be in `.easignore` 🙃

* Updated to follow #3285 etc.

* The translation of 'place' and 'apply' of labels has been unified into '適用する'.

* Fix translation of "repost"

* Updated

* Updated Japanese translation

* Updated Japanese translation

- #3816

* Fixed translations

* Updated translation : #3995

* Updated Japanese translation

* Updated Japanese translation (ref. #3962 #4028)

* Updated Japanese translation

* Updated Japanese translation

* Updated Japanese translation

---------

Co-authored-by: Minseo Lee <[email protected]>
Co-authored-by: Jan-Olof Eriksson <[email protected]>
Co-authored-by: Hailey <[email protected]>
@haileyok haileyok deleted the hailey/fix-bash-bundle-action branch June 8, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants