-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve localization marks #3285
Conversation
You might want to add these toasts in the image picker to be localised: social-app/src/lib/media/picker.shared.ts Line 18 in 6f2dfcb
social-app/src/lib/media/picker.shared.ts Line 25 in 6f2dfcb
|
@pfrazee Hello, can I ask you to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep this all looks solid. Thanks so much, quiple!
* Update Lightbox.tsx * Change strings for easier localization * Update DeleteAccount.tsx * Update LabelsOnMeDialog.tsx * Update FeedCard.tsx * Update index.tsx * Update LabelsOnMeDialog.tsx * Update index.tsx * Update FeedCard.tsx * Update SelfLabel.tsx * Update Hashtag.tsx * Update index.tsx * Update Hashtag.tsx * Update ChangeHandle.tsx * Update index.web.tsx * Update index.web.tsx * Update index.tsx * Remove unnecessary `<Trans>` tags * Update Drawer.tsx
* Update Japanese translations * Updated as PR on Plural is merged (#3882) * Feedback API (#3498) etc. * Improve localization marks (#3285) * Update Lightbox.tsx * Change strings for easier localization * Update DeleteAccount.tsx * Update LabelsOnMeDialog.tsx * Update FeedCard.tsx * Update index.tsx * Update LabelsOnMeDialog.tsx * Update index.tsx * Update FeedCard.tsx * Update SelfLabel.tsx * Update Hashtag.tsx * Update index.tsx * Update Hashtag.tsx * Update ChangeHandle.tsx * Update index.web.tsx * Update index.web.tsx * Update index.tsx * Remove unnecessary `<Trans>` tags * Update Drawer.tsx * Finnish translation update (#3755) * Update messages.po Translated new strings (GIF's etc) and cleaned up deprecated ones. * Update messages.po resolve conflict * Update messages.po removed double quotes. Thanks @lapanti * fix bad bool check in action (#3885) * fix bad bool check in action * add `fetch-depth` so we can get the commit hash * `.env` should be in `.easignore` 🙃 * Updated to follow #3285 etc. * The translation of 'place' and 'apply' of labels has been unified into '適用する'. * Fix translation of "repost" * Updated * Updated Japanese translation * Updated Japanese translation - #3816 * Fixed translations * Updated translation : #3995 * Updated Japanese translation * Updated Japanese translation (ref. #3962 #4028) * Updated Japanese translation * Updated Japanese translation * Updated Japanese translation --------- Co-authored-by: Minseo Lee <[email protected]> Co-authored-by: Jan-Olof Eriksson <[email protected]> Co-authored-by: Hailey <[email protected]>
Changes the position of
<Trans>
for easier localization.Changes the position of
<Trans>
for localization in languages with reversed word order.Replaces the right margin with a whitespace and changes the position of
<Trans>
for easier localization.Enables localization of these strings.
Removes trailing periods, as do many other toast messages used in Bluesky.
Removes unnecessary
<Trans>
tags.