Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early return function BeginBlocker #705

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Early return function BeginBlocker #705

merged 3 commits into from
Oct 17, 2023

Conversation

neitdung
Copy link
Contributor

1. Summary

Fixes #702

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #705 (2095b53) into main (5adcf20) will decrease coverage by 0.01%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   13.40%   13.40%   -0.01%     
==========================================
  Files         243      243              
  Lines       63040    63049       +9     
==========================================
  Hits         8452     8452              
- Misses      53913    53919       +6     
- Partials      675      678       +3     
Flag Coverage Δ
unittests 13.40% <48.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
x/interchainstaking/keeper/abci.go 35.18% <48.14%> (-7.04%) ⬇️

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ThanhNhann ThanhNhann merged commit 7521baa into main Oct 17, 2023
11 of 12 checks passed
@ThanhNhann ThanhNhann deleted the neitdung/early-return branch October 17, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/interchainstaking/keeper: please use early returns as idiomatic code and reduce nesting
3 participants