x/interchainstaking/keeper: please use early returns as idiomatic code and reduce nesting

[odeke-em]

Summary of Bug

This code section

quicksilver/x/interchainstaking/keeper/abci.go

Lines 50 to 73 in a24dc70

	connection, found := k.IBCKeeper.ConnectionKeeper.GetConnection(ctx, zone.ConnectionId)
	if found {
	consState, found := k.IBCKeeper.ClientKeeper.GetLatestClientConsensusState(ctx, connection.GetClientID())
	if found {
	tmConsState, ok := consState.(*tmtypes.ConsensusState)
	if ok {
	if len(zone.IbcNextValidatorsHash) == 0 || !bytes.Equal(zone.IbcNextValidatorsHash, tmConsState.NextValidatorsHash.Bytes()) {
	k.Logger(ctx).Info("IBC ValSet has changed; requerying valset")
	// trigger valset update.
	period := int64(k.GetParam(ctx, types.KeyValidatorSetInterval))
	query := stakingTypes.QueryValidatorsRequest{}
	err := k.EmitValSetQuery(ctx, zone.ConnectionId, zone.ChainId, query, sdkmath.NewInt(period))
	if err != nil {
	k.Logger(ctx).Error("unable to trigger valset update query", "error", err.Error())
	// failing to emit the valset update is not terminal but constitutes
	// an error, as if this starts happening frequent it is something
	// we should investigate.
	}
	zone.IbcNextValidatorsHash = tmConsState.NextValidatorsHash.Bytes()
	k.SetZone(ctx, zone)
	}
	}
	}
	}

could be improved by following https://cyber.orijtech.com/scsec/cosmos-go-coding-guide#reduce-code-nesting-with-early-returns-and-inversions

Expected Behaviour

connection, found := k.IBCKeeper.ConnectionKeeper.GetConnection(ctx, zone.ConnectionId) 
if !found { 
      return false
}

consState, found := k.IBCKeeper.ClientKeeper.GetLatestClientConsensusState(ctx, connection.GetClientID()) 
if !found { 
       return false
}
 		
tmConsState, ok := consState.(*tmtypes.ConsensusState) 
if !ok {
      return false
}

changedValSet := len(zone.IbcNextValidatorsHash) == 0 || !bytes.Equal(zone.IbcNextValidatorsHash, tmConsState.NextValidatorsHash.Bytes())
if !changedValSet {
      return false
}
 
k.Logger(ctx).Info("IBC ValSet has changed; requerying valset") 
// trigger valset update. 
period := int64(k.GetParam(ctx, types.KeyValidatorSetInterval)) 
query := stakingTypes.QueryValidatorsRequest{} 
err := k.EmitValSetQuery(ctx, zone.ConnectionId, zone.ChainId, query, sdkmath.NewInt(period)) 
if err != nil { 
 	k.Logger(ctx).Error("unable to trigger valset update query", "error", err.Error()) 
 	// failing to emit the valset update is not terminal but constitutes 
 	// an error, as if this starts happening frequent it is something 
 	// we should investigate. 
} 

zone.IbcNextValidatorsHash = tmConsState.NextValidatorsHash.Bytes() 
k.SetZone(ctx, zone) 

/cc @elias-orijtech @joe-bowman

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned