feat: mapped account query #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajansari95 lint fail. I think you just need to run formatting |
Codecov Report
@@ Coverage Diff @@
## feat/keytypes #443 +/- ##
=================================================
- Coverage 54.22% 54.20% -0.03%
=================================================
Files 164 164
Lines 12179 12241 +62
=================================================
+ Hits 6604 6635 +31
- Misses 5070 5099 +29
- Partials 505 507 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joe-bowman
reviewed
Jun 2, 2023
joe-bowman
reviewed
Jun 2, 2023
aljo242
reviewed
Jun 2, 2023
Co-authored-by: Alex Johnson <[email protected]>
ajansari95
commented
Jun 2, 2023
ajansari95
commented
Jun 2, 2023
Comment on lines
+2902
to
+2920
| for k := range m.RemoteAddressMap { | ||
| v := m.RemoteAddressMap[k] | ||
| baseI := i | ||
| if len(v) > 0 { | ||
| i -= len(v) | ||
| copy(dAtA[i:], v) | ||
| i = encodeVarintQuery(dAtA, i, uint64(len(v))) | ||
| i-- | ||
| dAtA[i] = 0x12 | ||
| } | ||
| i -= len(k) | ||
| copy(dAtA[i:], k) | ||
| i = encodeVarintQuery(dAtA, i, uint64(len(k))) | ||
| i-- | ||
| dAtA[i] = 0xa | ||
| i = encodeVarintQuery(dAtA, i, uint64(baseI-i)) | ||
| i-- | ||
| dAtA[i] = 0xa | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
aljo242
approved these changes
Jun 2, 2023
joe-bowman
pushed a commit
that referenced
this pull request
Jun 7, 2023
* add to proto * generate * populate field * Update proto/quicksilver/interchainstaking/v1/interchainstaking.proto Co-authored-by: Ajaz Ahmed Ansari <[email protected]> * decode basic implementation * decodememo * fix * decode Field * lint fix * parse memo fields * stub out logic * address map * address map * refactor * lint fix * validate memo fields * add logic * refactor * feat: mapped account query (#443) * add mapped account query * format * rebase * return map instead of struct * Update x/interchainstaking/client/cli/query.go Co-authored-by: Alex Johnson <[email protected]> * Update x/interchainstaking/keeper/grpc_query.go * Update x/interchainstaking/keeper/grpc_query_test.go * fix lint * use sdkConfig --------- Co-authored-by: Alex Johnson <[email protected]> * refactor to cover more cases * update * send on remote zone * add condition * Update x/interchainstaking/types/zones_test.go * Update x/interchainstaking/types/zones_test.go * Update x/interchainstaking/types/zones_test.go remove unused import * Update x/interchainstaking/types/zones_test.go --------- Co-authored-by: Ajaz Ahmed Ansari <[email protected]> Co-authored-by: Joe Bowman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes QCK-477
Adds Mapped Account query for xcclookup
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)