feat: mapped accounts #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 18, 2023 09:53
ajansari95
reviewed
May 18, 2023
Co-authored-by: Ajaz Ahmed Ansari <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #436 +/- ##
===========================================
- Coverage 54.47% 54.38% -0.10%
===========================================
Files 163 164 +1
Lines 12045 12255 +210
===========================================
+ Hits 6562 6665 +103
- Misses 4987 5087 +100
- Partials 496 503 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joe-bowman
reviewed
May 23, 2023
There was a problem hiding this comment.
Looks good so far;
xcclookup will require a new query type to return map of addresses, indexed by chain ID (I don't think we need them bech32ified, because the first thing we do in xcclookup is decode the address anyway) for a given address:
/quicksilver/interchainstaking/v1/mapped_addresses/quick1abcdef
which is why we prefix the local address mapping by address and not chain, so we prefix iterator over it for this query :)
if we do, we will need to add the account prefix to the ProtocolDataConnection structs
joe-bowman
reviewed
Jun 2, 2023
* add mapped account query * format * rebase * return map instead of struct * Update x/interchainstaking/client/cli/query.go Co-authored-by: Alex Johnson <[email protected]> * Update x/interchainstaking/keeper/grpc_query.go * Update x/interchainstaking/keeper/grpc_query_test.go * fix lint * use sdkConfig --------- Co-authored-by: Alex Johnson <[email protected]>
joe-bowman
reviewed
Jun 5, 2023
joe-bowman
reviewed
Jun 5, 2023
joe-bowman
reviewed
Jun 5, 2023
joe-bowman
requested changes
Jun 5, 2023
added 2 commits
June 6, 2023 12:38
joe-bowman
reviewed
Jun 7, 2023
joe-bowman
reviewed
Jun 7, 2023
ajansari95
reviewed
Jun 7, 2023
remove unused import
joe-bowman
reviewed
Jun 7, 2023
ajansari95
reviewed
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes QCK-452
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)